Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KNI][release-4.14][manual] pfpstatus: fix BaseDirectory bug #124

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

ffromani
Copy link
Member

@ffromani ffromani commented Oct 7, 2023

A typo disallowed user setting override of the builtin BaseDirectory. Turns out the builtin default is not needed or used, so remove it.

A typo disallowed user setting override of the builtin BaseDirectory.
Turns out the builtin default is not needed or used, so remove it.

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2023
@ffromani
Copy link
Member Author

ffromani commented Oct 7, 2023

manual backport of #123

@ffromani ffromani merged commit 1e20f0b into release-4.14 Oct 7, 2023
3 checks passed
@ffromani ffromani deleted the kni-pfpstatus-4.14 branch October 7, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant