ARO-5950 | feat: add initial ARO-HCP Azure attributes #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsorianod
commented
Apr 10, 2024
|
|
||
| // Microsoft Azure settings of a cluster. | ||
| struct Azure { | ||
| // [Required] The Azure Subscription ID associated with the cluster. It must belong to `tenant_id`. |
There was a problem hiding this comment.
Unfortunately we can't configure a required OpenAPI attribute with the metamodel so we document it
|
lgtm 👍 |
zgalor
reviewed
Apr 10, 2024
miguelsorianod
force-pushed
the
add-initial-arohcp-azure-attrs
branch
from
fa5ad7d
to
5bfb2a4
Compare
machi1990
approved these changes
Apr 10, 2024
miguelsorianod
force-pushed
the
add-initial-arohcp-azure-attrs
branch
from
5bfb2a4
to
208a4e1
Compare
miguelsorianod
changed the title
machi1990
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial set of attributes for ARO-HCP clusters. These will be needed when creating ARO-HCP clusters.
The set of attributes in this PR is only the initial ones, that we know should be needed. More will be added over time and there is work in progress to identify and design them. Future PRs will be created for those.