Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add initial ARO-HCP Azure Node Pool attributes #944

Merged
merged 1 commit into from
May 31, 2024
Merged

feat: add initial ARO-HCP Azure Node Pool attributes #944

merged 1 commit into from
May 31, 2024

Conversation

miguelsorianod
Copy link
Contributor

machi1990
machi1990 approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

left one comment regarding updating a TODO comment on the CS side api level which is stale if confirmation has been done on the vm_size being required

@miguelsorianod miguelsorianod merged commit e99569a into openshift-online:main May 31, 2024
2 checks passed
@miguelsorianod miguelsorianod deleted the add-azure-nodepool-attrs branch May 31, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@oriAdler oriAdler Awaiting requested review from oriAdler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelsorianod @machi1990