feat: convert os_disk_size_gibibytes in azure node pool to integer #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We convert the os_disk_size_gibibytes type from string to integer to match the type that is used in Azure ARM.
miguelsorianod
changed the title
miguelsorianod
changed the title
Merged
machi1990
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We convert the os_disk_size_gibibytes type from string to integer to match the type that is used in Azure ARM.
Even though changing the API type is considered a breaking change, this belongs to Azure Node Pools which we know at the moment of writing this no customer is using it and it is not available in OCM Commercial so it is fine changing this.
There is a corresponding MR in CS to perform the corresponding server side changes.