Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test for when concurrency and startPR error
when we cannot create the PipelineRun and we got an error from the controller, if we had concurrency set the controller would crash. This was fixed in e553256 but added test for this ``` 💡 11:25:51 pac-controller pipelinerun test-gh-kjtd8 has been created in namespace pac-e2e-ns-7bw6b for SHA: 4a82af8eb94e78576bc0f9ab3e1a7c5582825412 Target Branch: main 🚨 11:25:51 pac-controller There was an error starting the PipelineRun 00-bad-apple-tdza-, creating pipelinerun 00-bad-apple-tdza- in namespace pac-e2e-ns-7bw6b has failed. Tekton Controller has reported this error: ```admission webhook "validation.webhook.pipeline.tekton.dev" denied the request: validation failed: invalid value: couldn't add link between noexist and donotexist: task noexist depends on donotexist but donotexist wasn't present in Pipeline: spec.pipelineSpec.tasks``` 💡 11:25:52 pac-controller patched pipelinerun with checkRunID and logURL: pac-e2e-ns-7bw6b/test-gh-1-6x879 💡 11:25:52 pac-controller patched pipelinerun with checkRunID and logURL: pac-e2e-ns-7bw6b/test-gh-kjtd8 💡 11:25:52 pac-controller patched pipelinerun with checkRunID and logURL: pac-e2e-ns-7bw6b/prlongrunnning-1-fjrs-qckbv 💡 11:25:52 pac-controller patched pipelinerun with checkRunID and logURL: pac-e2e-ns-7bw6b/test-gh-2-tjdwf 💡 11:25:52 pac-controller skipping event: check_run: unsupported action "created" 💡 11:25:52 pac-controller skipping event: check_run: unsupported action "created" 💡 11:25:52 pac-controller skipping event: check_run: unsupported action "created" 💡 11:25:52 pac-controller skipping event: check_run: unsupported action "created" 💡 11:25:52 pac-controller skipping event: check_run: unsupported action "created" pipelines-as-code/ghe-controller-6b68d9cfb-dc6lg[pac-controller]: panic: reflect: call of reflect.Value.Interface on zero Value pipelines-as-code/ghe-controller-6b68d9cfb-dc6lg[pac-controller]: pipelines-as-code/ghe-controller-6b68d9cfb-dc6lg[pac-controller]: goroutine 563 [running]: pipelines-as-code/ghe-controller-6b68d9cfb-dc6lg[pac-controller]: reflect.valueInterface({0x0?, 0x0?, 0x4000da0d40?}, 0xe0?) pipelines-as-code/ghe-controller-6b68d9cfb-dc6lg[pac-controller]: reflect/value.go:1501 +0xfc pipelines-as-code/ghe-controller-6b68d9cfb-dc6lg[pac-controller]: ``` fixing and add e2e tests for it.
- Loading branch information