Allow setting policies on actions #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmouel
changed the title
Golang test coverage difference reportCoverage increased by Package report |
|
weird, things are green for me locally when running the test locally |
chmouel
force-pushed
the
policies-setting
branch
from
30657de
to
b3c3fba
Compare
|
nevermind the other comment the error was legitimate |
|
what does |
|
@sm43 it's this * `pull_request` - This action is triggering the CI on Pipelines as Code,
specifying a team will only allow the members of the team to trigger the CI
and will not allow other members regadless if they are Owners or Collaborators
of the repository or the Organization. The OWNERS file is still taken into
account and will as well allow the members of the OWNERS file to trigger the
CI. |
sm43
reviewed
Jun 22, 2023
chmouel
force-pushed
the
policies-setting
branch
from
b3c3fba
to
688e38d
Compare
| - ci-users | ||
| ``` | ||
|
|
||
| Users in `ci-admins` team will be able to let other users run the CI on the pull |
There was a problem hiding this comment.
I feel explanation is somewhat confusing to tell the exact operation which ci-admins can do
May its for me 🤔
There was a problem hiding this comment.
is that less confusing ? (chatgpt)
To set up the policy for the Repository CR, follow these steps:
- Open the settings of the Repository CR.
- Add the following code snippet to the configuration:
apiVersion: "pipelinesascode.tekton.dev/v1alpha1"
kind: Repository
metadata:
name: repository1
spec:
url: "https://github.com/org/repo"
settings:
policy:
ok_to_test:
- ci-admins
pull_request:
- ci-usersThis configuration allows specific user groups to perform certain actions on pull requests:
- Users in the
ci-adminsteam can authorize other users to run continuous integration (CI) on the pull request. - Users in the
ci-usersteam can run CI on their own pull requests.
There was a problem hiding this comment.
@chmouel this is easy to understand 👍
|
/retest |
Codecov Report
@@ Coverage Diff @@
## main #1324 +/- ##
==========================================
+ Coverage 60.36% 60.62% +0.25%
==========================================
Files 135 136 +1
Lines 9722 9839 +117
==========================================
+ Hits 5869 5965 +96
- Misses 3377 3396 +19
- Partials 476 478 +2
|
so we can reuse it later on
Policies is a new concept which let you allowing teams to do some actions and reject member who are not part of those teams. Current actions supported are `pull_request` and `ok_to_test` (more to come in the future) See the documentation attached to this PullRequest for more description on how to use this feature. Signed-off-by: Chmouel Boudjnah <[email protected]>
with regard to the latest change setting pipelinerunpending before running it. we need to make sure we only get the latest status to properly test Signed-off-by: Chmouel Boudjnah <[email protected]>
When the user is not allowed make sure we check the test are in Pending Approval Signed-off-by: Chmouel Boudjnah <[email protected]>
|
/lgtm |
1 similar comment
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policies is a new concept which let you allowing teams to do some
actions and reject member who are not part of those teams.
Current actions supported are
pull_requestandok_to_test(more tocome in the future)
See the documentation attached to this PullRequest for more description
on how to use this feature.