Not list configmaps in all namespaces #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyush-garg
force-pushed
the
fix_pac_resolve
branch
from
2c68a77
to
8102da0
Compare
piyush-garg
changed the title
| } | ||
| } | ||
| return installed, "", fmt.Errorf("could not detect Pipelines as Code configmap on the cluster, please reinstall") | ||
| if configMap == nil { | ||
| return nil, fmt.Errorf("ConfigMap not found in default namespaces") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("ConfigMap not found in default namespaces") | |
| return nil, fmt.Errorf("ConfigMap not found in default namespaces("openshift-pipelines", "pipelines-as-code") |
or something
because the word default namespaces conflict with actual k8s/openshift default ns
|
i don't think there is people (that i know) that runs pac in other namespace than openshift/pipelines-as-code so that's fine |
chmouel
force-pushed
the
main
branch
6 times, most recently
from
cb88d0e
to
7260744
Compare
|
/retest |
|
/retest would not rebase the commit, i clicked on the update branch button for you.... |
piyush-garg
force-pushed
the
fix_pac_resolve
branch
from
5c0e47a
to
2312fa0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1357 +/- ##
==========================================
+ Coverage 60.73% 60.94% +0.21%
==========================================
Files 136 136
Lines 9916 9929 +13
==========================================
+ Hits 6022 6051 +29
+ Misses 3411 3394 -17
- Partials 483 484 +1
|
This commit makes the changes to detect pac installation only in default namespace i.e. pipelines-as-cdoe and openshift-pipelines or other if provided by user through --pac-namespace flag This makes the tkn pac create repo command usable for non-admin users too But on the other side, it will be a breaking change for admin users who have pac installed in some other namespace and were using the commands without pac-namespace flag till now It will affect tkn pac create repo, tkn pac bootstrap and tkn pac webhook add commands for users who had permissions till now and were not using --pac-namespace flag
piyush-garg
force-pushed
the
fix_pac_resolve
branch
from
2312fa0
to
00d3fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the changes to detect pac installation only in
default namespace i.e. pipelines-as-cdoe and openshift-pipelines
or other if provided by user through --pac-namespace flag
This makes the tkn pac create repo command usable for
non-admin users too
But on the other side, it will be a breaking change for admin users
who have pac installed in some other namespace and were
using the commands without pac-namespace flag till now
It will affect tkn pac create repo, tkn pac bootstrap and
tkn pac webhook add commands for users who had permissions till now
and were not using --pac-namespace flag
Submitter Checklist
make testbefore submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and dopre-commit installin the root of this repo).make lintbefore submitting a PR. The markdownlint error can get usually fixed by runningmake fix-markdownlint(make sure it's installed first)