Fix the branchMatching for refs/tags

[piyush-garg]

This will fix the branchMatching handling where we were missing handling the scenario of refs/tags

Also adding unit test for scenarios that can happen for branchMatching

Submitter Checklist

• 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
• ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
• ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
• 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
• 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
• 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
• 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

[codecov]

Codecov Report

Merging #1387 (ed5f2d0) into main (557ccab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1387   +/-   ##
=======================================
  Coverage   60.97%   60.98%           
=======================================
  Files         136      136           
  Lines        9934     9936    +2     
=======================================
+ Hits         6057     6059    +2     
  Misses       3392     3392           
  Partials      485      485           

Files Changed	Coverage Δ
pkg/matcher/annotation_matcher.go	95.39% <100.00%> (+0.06%)	⬆️

[chmouel]

let me test your change locally, we should get a e2e next time..

[chmouel]

sounds like it's working for me (but so is my revert tho :))

it's good to go for me, un less @savitaashture thinks otherwise