Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for tektondir interceptor service #1405

Closed

Conversation

piyush-garg
Copy link
Member

Submitter Checklist

  • 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
  • ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
  • ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (c0e0e5d) 62.91% compared to head (1c9f97d) 62.34%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/pipelineascode/tekton_dir_interceptor.go 0.00% 80 Missing ⚠️
pkg/pipelineascode/match.go 72.72% 5 Missing and 1 partial ⚠️
pkg/params/settings/config.go 0.00% 3 Missing and 1 partial ⚠️
pkg/params/settings/validation.go 0.00% 3 Missing and 1 partial ⚠️
pkg/provider/bitbucketcloud/bitbucket.go 0.00% 2 Missing ⚠️
pkg/provider/bitbucketserver/bitbucketserver.go 0.00% 2 Missing ⚠️
pkg/provider/gitea/gitea.go 0.00% 2 Missing ⚠️
pkg/provider/github/github.go 0.00% 2 Missing ⚠️
pkg/provider/gitlab/gitlab.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   62.91%   62.34%   -0.58%     
==========================================
  Files         130      131       +1     
  Lines       10421    10542     +121     
==========================================
+ Hits         6556     6572      +16     
- Misses       3345     3446     +101     
- Partials      520      524       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piyush-garg piyush-garg force-pushed the imple_resolver branch 2 times, most recently from b3c40ba to 8f0ed4a Compare September 7, 2023 07:42
@chmouel
Copy link
Member

chmouel commented Nov 2, 2023

/retest

@chmouel
Copy link
Member

chmouel commented Nov 2, 2023

/test linters

(testing some unrelated stuff to your pr)

@chmouel
Copy link
Member

chmouel commented Nov 2, 2023

/test linters

@piyush-garg piyush-garg changed the title POC: Implementing external resolver service WIP: Add support for tektondir interceptor service Nov 6, 2023
@piyush-garg piyush-garg force-pushed the imple_resolver branch 2 times, most recently from 7327725 to 6a5544d Compare November 7, 2023 08:02
This adds support for tektondir interceptor service
to provide piplineruns irrespective of the .tekton
dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants