Add a better status message #1492
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
=======================================
Coverage 61.63% 61.64%
=======================================
Files 138 137 -1
Lines 10294 10371 +77
=======================================
+ Hits 6345 6393 +48
- Misses 3436 3461 +25
- Partials 513 517 +4
☔ View full report in Codecov by Sentry. |
|
lgtm |
chmouel
force-pushed
the
better-status-message
branch
from
81b006c
to
7c0cbe7
Compare
| variable: | ||
|
|
||
| * `{{ namespace }}`: The target namespace where the pipelinerun is executed | ||
|
|
There was a problem hiding this comment.
Can you add a example format how it looks like after adding {{ namespace }}
I mean something similar to what added in custom-console-url-pr-details
example: https://mycorp.com/ns/{{ namespace }}/pipelinerun/{{ pr }}
There was a problem hiding this comment.
what do you mean for openshift? you only need this if you have a custom console and do not use the openshift console, you can have a custom console when running on openshift
| @@ -250,6 +250,16 @@ A few settings are available to configure this feature: | |||
|
|
|||
| Set this to the root URL of your custom console. example: `https://mycorp.com` | |||
|
|
|||
| * `custom-console-url-namespace` | |||
There was a problem hiding this comment.
For openshift we don't need to set this right ?
asking because when i test this changes i don't see namespace i details 🤔
There was a problem hiding this comment.
I mean i tried manually i don't see Namespace and PR name in details 🤔
chmouel
force-pushed
the
better-status-message
branch
from
7c0cbe7
to
db79ade
Compare
|
/retest |
We are adding a better status message that will include the Namespace and the PipelineRun. We link the Namespace to the Namespace view in the consoles. Introducing a new setting for that `custom-console-url-namespace` that would need to be setup when using a custom console. Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
better-status-message
branch
from
db79ade
to
d30554f
Compare
|
/test linters |
|
I installed this PR on dogfooding cluster you can see the example here: https://github.com/openshift-pipelines/pipelines-as-code/pull/1492/checks?check_run_id=18482061202 redid most of the test reconciler to test this properly (it didn't before) with golden |
|
Verified on dogfooding cluster for both success and failure
|
We are adding a better status message that will include the Namespace and the PipelineRun.
We link the Namespace to the Namespace view in the consoles.
Introducing a new setting for that
custom-console-url-namespacethat would need to be setup when using a custom console.Changes
Submitter Checklist
make testbefore submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and dopre-commit installin the root of this repo).make lintbefore submitting a PR. The markdownlint error can get usually fixed by runningmake fix-markdownlint(make sure it's installed first)