Fix Azure and GCP INFRA WORKLOAD configuration related issues #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiliRedHat
changed the title
qiliRedHat
force-pushed
the
cluster-post-config-fix-aure-location
branch
from
79ff985 to
a83b4ac
Compare
|
Tested with Job https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/qili-e2e-benchmark/job/cluster-post-config-fix-aure-location/8/ successfully |
|
@paigerube14 Please take a look at #148 and let me know if you still want to pass the location as parameter. |
paigerube14
reviewed
May 16, 2022
| @@ -6,7 +6,7 @@ metadata: | |||
| ${MACHINESET_METADATA_LABEL_PREFIX}/cluster-api-cluster: ${CLUSTER_NAME} | |||
| ${MACHINESET_METADATA_LABEL_PREFIX}/cluster-api-machine-role: workload | |||
| ${MACHINESET_METADATA_LABEL_PREFIX}/cluster-api-machine-type: workload | |||
| name: workload-${CLUSTER_NAME} | |||
There was a problem hiding this comment.
I think we still need to leave cluster_name in the name of the object to be able to properly run destroy.
There was a problem hiding this comment.
@paigerube14 Thanks for pointing this out. I added ${CLUSTER_NAME} to all INFRA and WORKLOAD machinesets' name
|
I did try with a cluster that was in the northcentralus zone and because it has no availability zones the infra and workload nodes failed to create. Think we can go ahead with this code because it makes it more robust. Maybe we need to add a common errors section to the readme for this branch? Thoughts? |
qiliRedHat
force-pushed
the
cluster-post-config-fix-aure-location
branch
from
57dade4 to
9b2e1cf
Compare
|
Now machinesets name looks like |
|
Found monitoring co degraded. The alertmanager and prometheus-k8s pods were not successfully created on INFRA nodes. Root cause is the storage class configured by our job by default not correct. I changed it to the default storageclass managed-csi on Azure, everything works. Updated the description of the ENV_VARS for Azure to the correct storage class name. |
|
@paigerube14 merged commits, please take a look again. Thanks. |
|
Opened #152 to fix the default value passed by cluster-workers-scaling |
qiliRedHat
force-pushed
the
cluster-post-config-fix-aure-location
branch
from
64eaf5b to
c7d1796
Compare
…, add cluster name to machieset name prefix, add comment to README that Azure only support region: centralus. Add infra and workload label to metadata of GCP machinesets add infra and workload label to metadata of GCP machinesets
qiliRedHat
force-pushed
the
cluster-post-config-fix-aure-location
branch
from
91ed48c to
a2640ed
Compare
qiliRedHat
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paigerube14, qiliRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #148 and #153
Summary of changes:
managed-csiregion: centralus