MGMT-19708: Ignore mirrored registries when validating pull secrets #7193
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@CrystalChun: This pull request references MGMT-19708 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
CrystalChun
force-pushed
the
no-auth-mirror
branch
from
483c854 to
43506db
Compare
openshift-ci
bot
added
size/L
|
/test ? |
|
@CrystalChun: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test edge-subsystem-kubeapi-aws |
CrystalChun
force-pushed
the
no-auth-mirror
branch
13 times, most recently
from
19290db to
2810932
Compare
openshift-ci
bot
added
size/S
CrystalChun
force-pushed
the
no-auth-mirror
branch
from
2810932 to
4b05fd7
Compare
openshift-ci
bot
removed
the
size/S
openshift-ci
bot
added
the
size/L
CrystalChun
force-pushed
the
no-auth-mirror
branch
2 times, most recently
from
72bda3b to
6bb5c8d
Compare
openshift-ci
bot
added
size/XL
CrystalChun
force-pushed
the
no-auth-mirror
branch
from
6bb5c8d to
f7aabe0
Compare
|
@CrystalChun: This pull request references MGMT-19708 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
When a mirror registry configuration is provided to assisted, we will assume that the registry does not require authentication. This will take any mirror registry that assisted is configured with and will add it to the public registries list in the pull secret validator. That way, any pull secret being validated will not be required to have authentication credentials for the registry since it's pulling from the mirror. This is a better user experience so that the user will not have to provide credentials for a registry if a mirror registry will be used in its place.
This allows additional public registries to be specified when validating pull secrets. One case is when a cluster has a mirror registry configuration.
If a cluster or infra env has a mirror registry configuration, we'll parse those to create a list of additional registries that can be ignored when validating the pull secret.
Updates the installer and the pull secret validation mock files for the new parameter.
To use the new parameter
CrystalChun
force-pushed
the
no-auth-mirror
branch
from
f7aabe0 to
8d2866e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7193 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.02%
==========================================
Files 296 296
Lines 40459 40497 +38
==========================================
+ Hits 27394 27413 +19
- Misses 10605 10617 +12
- Partials 2460 2467 +7
|
|
@CrystalChun: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When a mirror registry configuration is provided to assisted, we will assume that the registry does not require authentication. This is a better user experience so that the user will not have to provide credentials for a registry if a mirror registry will be used in its place.
I've broken up the commits so that the first commit is for mirror configuration in assisted (globally) and the following commits are for mirror configurations per cluster.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist