Use sonic instead of standard json library #7352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test ? |
|
@adriengentil: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test edge-subsystem-kubeapi-aws edge-subsystem-aws edge-unit-test edge-e2e-metal-assisted-4-18 |
|
/cc @rccrdpccl |
adriengentil
changed the title
|
/test edge-subsystem-kubeapi-aws edge-subsystem-aws |
|
@adriengentil: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last investigations have shown that assisted spend a lot of time de-serializing json, and it can struggle at processing large inventories.
sonic is a performant json library that can help the assisted at coping with these scalability issues. The advantage of this library is that is it an almost drop-in library for the standard json library: to keep the maximum compatibility, I ensured that we used
ConfigStdon marshaling operations because it makes the json strings comparable (keys will be sorted).I did not update the
pkg/folder to avoid public users of our library to be forced to use this library.Memory is slightly higher:
CPU usage is divided by 2:
p90 time to monitor a host is divided by 5:
average time to monitor a host is divided by 3.5:
