[release-ocm-2.7] Update default tag for index and service #2018

adriengentil · 2023-01-30T12:39:14Z

e2e-metal-assisted-ha-kube-api-ipv6, e2e-metal-assisted-kube-api-late-binding-single-node and e2e-metal-assisted-kube-api-late-unbinding-single-node jobs are currently permafailing.

I suspect it's because the index not being aligned with branch version.

osherdp · 2023-01-30T12:53:11Z

Makefile

@@ -42,9 +42,9 @@ CONTAINER_RUNTIME_COMMAND := $(or ${CONTAINER_COMMAND}, ${CONTAINER_RUNTIME_COMM
 LINT_CODE_STYLING_DIRS := src/tests src/triggers src/assisted_test_infra/test_infra src/assisted_test_infra/download_logs src/service_client src/consts src/virsh_cleanup src/cli

 # assisted-service
-SERVICE := $(or $(SERVICE), quay.io/edge-infrastructure/assisted-service:latest)
+SERVICE := $(or $(SERVICE), quay.io/edge-infrastructure/assisted-service:ocm-2.7)


I wonder if we can make some adjustments that don't demand us to handle all those tag changes for the branches
I mean, if anything I would assume we override SERVICE somewhere to use the right service image, and not use the default. Is it not the case?

You're right, I'll see if I can do it from release repo

and yes SERVICE shouldn't be required

you know what, maybe this change is good for easing local testing of this version

adriengentil · 2023-01-30T13:50:21Z

/test ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

openshift-ci · 2023-01-30T13:50:35Z

@adriengentil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-metal-assisted-kube-api-late-binding-single-node
/test e2e-metal-assisted-kube-api-net-suite
/test images
/test lint

The following commands are available to trigger optional jobs:

/test e2e-metal-assisted-ha-kube-api
/test e2e-metal-assisted-ha-kube-api-ipv4
/test e2e-metal-assisted-ha-kube-api-ipv6
/test e2e-metal-assisted-ipxe
/test e2e-metal-assisted-kube-api-late-unbinding-single-node
/test e2e-metal-assisted-kube-api-reclaim
/test e2e-metal-assisted-kube-api-reclaim-single-node
/test e2e-vsphere-assisted-kube-api

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adriengentil · 2023-01-30T14:16:00Z

/test ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node
looks like prow is flaky today...

openshift-ci · 2023-01-30T14:16:04Z

@adriengentil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-metal-assisted-kube-api-late-binding-single-node
/test e2e-metal-assisted-kube-api-net-suite
/test images
/test lint

The following commands are available to trigger optional jobs:

/test e2e-metal-assisted-ha-kube-api
/test e2e-metal-assisted-ha-kube-api-ipv4
/test e2e-metal-assisted-ha-kube-api-ipv6
/test e2e-metal-assisted-ipxe
/test e2e-metal-assisted-kube-api-late-unbinding-single-node
/test e2e-metal-assisted-kube-api-reclaim
/test e2e-metal-assisted-kube-api-reclaim-single-node
/test e2e-vsphere-assisted-kube-api

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node
looks like prow is flaky today...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adriengentil · 2023-01-30T14:17:03Z

/test e2e-metal-assisted-kube-api-late-binding-single-node

adriengentil · 2023-01-30T14:17:51Z

/test e2e-metal-assisted-ha-kube-api-ipv6
/test e2e-metal-assisted-kube-api-late-unbinding-single-node

adriengentil · 2023-01-30T14:28:55Z

/test e2e-metal-assisted-kube-api-late-binding-single-node

adriengentil · 2023-01-30T15:50:13Z

@osherdp @eliorerz e2e-metal-assisted-ha-kube-api-ipv6 seems broken:

# kubectl get agentclusterinstall/test-infra-cluster-f883c57c-agent-cluster-install -n assisted-spoke-cluster-fd412a8f -o yaml
apiVersion: extensions.hive.openshift.io/v1beta1
kind: AgentClusterInstall
spec:
  apiVIP: 1001:db9::64
  ingressVIP: 1001:db9::65
  networking:
    clusterNetwork:
    - cidr: 172.30.0.0/16
      hostPrefix: 23
    serviceNetwork:
    - 10.128.0.0/14
status:
  apiVIP: 1001:db9::64
  apiVIPs:
  - 1001:db9::64
  ingressVIP: 1001:db9::65
  ingressVIPs:
  - 1001:db9::65
  machineNetwork:
  - cidr: 1001:db9::/120
  validationsInfo:
    network:
    - id: networks-same-address-families
      message: Address families of networks (MachineNetworks, ServiceNetworks, ClusterNetworks)
        are not the same.
      status: failure

it seems we provide IPv4 addresses to the configuration and as a consequence, the validation fails because we mix IPv4/6. Does it ring a bell to you?

osherdp · 2023-01-30T16:21:52Z

it seems we provide IPv4 addresses to the configuration and as a consequence, the validation fails because we mix IPv4/6. Does it ring a bell to you?

I think (but really not sure anymore) that we're missing an override_cluster_configuration to set the required subnets in the ipv6 case. those two subnets for pods and services are given as input by the user, in oppose to the machine-network that is an "input" from the environment AFAIK

I am not sure how it happened though, maybe something we changed by mistake? Those jobs usually get less importance and treatment as the ztp ones are more comprehensive and simulate the use-case in a better way

You can open a bug on it, @eliorerz can probably debug it pretty quickly if needed

adriengentil · 2023-01-30T17:44:31Z

/retest

adriengentil · 2023-01-30T17:46:03Z

/override ci/prow/e2e-metal-assisted-ha-kube-api-ipv6
I'll open a bug for it

openshift-ci · 2023-01-30T17:46:41Z

@adriengentil: Overrode contexts on behalf of adriengentil: ci/prow/e2e-metal-assisted-ha-kube-api-ipv6

In response to this:

/override ci/prow/e2e-metal-assisted-ha-kube-api-ipv6
I'll open a bug for it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adriengentil · 2023-01-31T08:14:41Z

/override ci/prow/e2e-metal-assisted-ha-kube-api-ipv6
/test ci/prow/e2e-vsphere-assisted-kube-api

openshift-ci · 2023-01-31T08:14:46Z

@adriengentil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-metal-assisted-kube-api-late-binding-single-node
/test e2e-metal-assisted-kube-api-net-suite
/test images
/test lint

The following commands are available to trigger optional jobs:

/test e2e-metal-assisted-ha-kube-api
/test e2e-metal-assisted-ha-kube-api-ipv4
/test e2e-metal-assisted-ha-kube-api-ipv6
/test e2e-metal-assisted-ipxe
/test e2e-metal-assisted-kube-api-late-unbinding-single-node
/test e2e-metal-assisted-kube-api-reclaim
/test e2e-metal-assisted-kube-api-reclaim-single-node
/test e2e-vsphere-assisted-kube-api

Use /test all to run all jobs.

In response to this:

/override ci/prow/e2e-metal-assisted-ha-kube-api-ipv6
/test ci/prow/e2e-vsphere-assisted-kube-api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-01-31T08:14:59Z

@adriengentil: Overrode contexts on behalf of adriengentil: ci/prow/e2e-metal-assisted-ha-kube-api-ipv6

In response to this:

/override ci/prow/e2e-metal-assisted-ha-kube-api-ipv6
/test ci/prow/e2e-vsphere-assisted-kube-api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adriengentil · 2023-01-31T08:15:13Z

/test e2e-vsphere-assisted-kube-api

adriengentil · 2023-01-31T09:31:12Z

/test e2e-vsphere-assisted-kube-api

adriengentil · 2023-01-31T11:55:59Z

@osherdp let's merge it?

openshift-ci · 2023-01-31T12:24:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adriengentil,osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-01-31T15:19:49Z

@adriengentil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted-ha-kube-api-ipv6	`68c37df`	link	false	`/test e2e-metal-assisted-ha-kube-api-ipv6`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[release-ocm-2.7] Update default tag for index and service

e516d0d

adriengentil changed the base branch from master to release-ocm-2.7 January 30, 2023 12:39

adriengentil changed the title ~~release ocm 2.7~~ [release-ocm-2.7] Update default tag for index and service Jan 30, 2023

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2023

openshift-ci bot requested review from omertuc and osherdp January 30, 2023 12:40

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023

force abort current jobs

68c37df

osherdp reviewed Jan 30, 2023

View reviewed changes

adriengentil mentioned this pull request Jan 30, 2023

[release-ocm-2.7] Backport fix_uid.sh script #2016

Merged

osherdp approved these changes Jan 31, 2023

View reviewed changes

openshift-ci bot assigned osherdp Jan 31, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023

openshift-merge-robot merged commit 0b1e9dc into openshift:release-ocm-2.7 Jan 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-ocm-2.7] Update default tag for index and service #2018

[release-ocm-2.7] Update default tag for index and service #2018

adriengentil commented Jan 30, 2023 •

edited

Loading

osherdp Jan 30, 2023

adriengentil Jan 30, 2023

adriengentil Jan 30, 2023

osherdp Jan 30, 2023

adriengentil commented Jan 30, 2023

openshift-ci bot commented Jan 30, 2023

adriengentil commented Jan 30, 2023

openshift-ci bot commented Jan 30, 2023

adriengentil commented Jan 30, 2023

adriengentil commented Jan 30, 2023

adriengentil commented Jan 30, 2023

adriengentil commented Jan 30, 2023

osherdp commented Jan 30, 2023

adriengentil commented Jan 30, 2023

adriengentil commented Jan 30, 2023

openshift-ci bot commented Jan 30, 2023

adriengentil commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

adriengentil commented Jan 31, 2023

adriengentil commented Jan 31, 2023

adriengentil commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

[release-ocm-2.7] Update default tag for index and service #2018

[release-ocm-2.7] Update default tag for index and service #2018

Conversation

adriengentil commented Jan 30, 2023 • edited Loading

osherdp Jan 30, 2023

Choose a reason for hiding this comment

adriengentil Jan 30, 2023

Choose a reason for hiding this comment

adriengentil Jan 30, 2023

Choose a reason for hiding this comment

osherdp Jan 30, 2023

Choose a reason for hiding this comment

adriengentil commented Jan 30, 2023

openshift-ci bot commented Jan 30, 2023

adriengentil commented Jan 30, 2023

openshift-ci bot commented Jan 30, 2023

adriengentil commented Jan 30, 2023

adriengentil commented Jan 30, 2023

adriengentil commented Jan 30, 2023

adriengentil commented Jan 30, 2023

osherdp commented Jan 30, 2023

adriengentil commented Jan 30, 2023

adriengentil commented Jan 30, 2023

openshift-ci bot commented Jan 30, 2023

adriengentil commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

adriengentil commented Jan 31, 2023

adriengentil commented Jan 31, 2023

adriengentil commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

adriengentil commented Jan 30, 2023 •

edited

Loading