NO-ISSUE: Adjust OCI to work with UI flow #2624
Conversation
…rm output to the generated bucket.
|
@dudyas6: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dudyas6 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@dudyas6: GitHub didn't allow me to request PR reviews from the following users: talhil-rh, bkopilov. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dudyas6
force-pushed
the
add-oci-ui-support
branch
from
0983c18 to
6b5a000
Compare
|
@dudyas6: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| self._upload_data_to_bucket( | ||
| terraform_output, f"terraform-output-{self._entity_config.cluster_id}.yml", namespace, bucket_name | ||
| ) |
There was a problem hiding this comment.
already tackled here: #2605 (comment), can it be removed from this PR?
There was a problem hiding this comment.
I actually need it to upload the manifests in the UI flow instead of fetching it from the stack in someway, so i temporarily save it in /tmp folder, i can skip the upload to bucket part, but i'll still need to save it somewhere unless u have other suggestion
There was a problem hiding this comment.
well, we need to choose in which PR we want to talk about it, it's confusing at the moment, and I would need to understand why we need this file to be in the bucket.
Also I would need this cleanup logic be merged.
Re-opening #2609 after discussing with Elior
Work process of UI :
use make deploy_nodes_oci to deploy oci resources and leave them up, once ui flow finishes run make destroy_nodes_oci which finds all the used resources and removes them