Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch up with CI: rename controller's credentialsrequest to minify version #120

Merged
merged 1 commit into from
Nov 28, 2023
Merged

catch up with CI: rename controller's credentialsrequest to minify version #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ IAMCTL_OUTPUT_FILE ?= iam_policy.go
IAMCTL_GO_PACKAGE ?= awsloadbalancercontroller

# File name of the generated CredentialsRequest CR.
IAMCTL_OUTPUT_CR_FILE ?= ./hack/controller/controller-credentials-request.yaml
IAMCTL_OUTPUT_CR_FILE ?= ./hack/controller/controller-credentials-request-minify.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file name minify even though it isn't technically minified in release-1.0? Or it actually minified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually minified. I changed the name of the file in main 1) to better reflect its contents, 2) because 2 versions of the credentialsrequest are not published: minified and not minified.


# Built go binary path.
IAMCTL_BINARY ?= ./bin/iamctl
Expand Down
0 ...oller/controller-credentials-request.yaml → ...ontroller-credentials-request-minify.yaml
View file
Open in desktop
File renamed without changes.