Sync with main May-9-2022 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Add nirarg to the approvers list
Added a new CLI tool to manage the infra cluster. For now, the tool supports two commands: 1. `clusterkubevirtadm create credentials` this command creates a namespace, serviceAccount, role and roleBinding in the infra cluster. 2. `clusterkubevirtadm apply credentials` this command creates or updatea namespace, serviceAccount, role and roleBinding in the infra cluster. 3. `clusterkubevirtadm get kubeconfig` this command generates a kubeconfig file to use the serviceAccount created with the first command. The build the new tool, use: * `make clusterkubevirtadm-linux` - for linux application * `make clusterkubevirtadm-macos` - for macOS application * `make clusterkubevirtadm-win` - for windows application * `make clusterkubevirtadm-all` - for all the above + run the unit tests * `make clusterkubevirtadm-test` - to run the unit tests Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Added new CLI named clusterkubevirtadm, to manage the infra cluster
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
…wners Add nunnatsa to the approvers list
Add missing go compiler to the e2e test
…irtadm-fix This PR is a hotfix for the broken CI, it fixes a typo in the e2e workflow
…irtadm-fix clusterkubevirtadm-fix 2
Fix clusterkubevirtadm-linux-amd64 calling from e2e cluster creation workflow
Change clusterkubevirtadm to use --kubeconfig flag
This is not working for now, and fails the E2E test lane. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Restore the E2E test to not use clusterkubevirtadm
Signed-off-by: David Vossel <[email protected]>
The capk user need also permissions for the following resources In order to create the tenant cluster * virtualmachineinstances * secrets * services
…-role Add More permissions to clusterkubevirtadm Role
Fix the ginkgo dependencies to match v2
…k-storage-class Switch to using rook-ceph for e2e storage class
The capk user need also permissions for the following resources In order to create the tenant cluster * virtualmachineinstances * secrets * services
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
refactor: move environment context out of e2e tests logic
Signed-off-by: David Vossel <[email protected]>
Signed-off-by: David Vossel <[email protected]>
Signed-off-by: David Vossel <[email protected]>
Signed-off-by: David Vossel <[email protected]>
…m kubeconfig This commit changes kubevirtci to behave like the tenant cluster is created on ext infra This is done in order to test the cluster creation with clusterkubevirtadm limited kubeconfig This will also allow us to follow another resources would be added in the future to the tenant cluster creation Notice: added special behavior for kubevirtci, in which the "localhost" IP in the kubeconfig is replaced with the controlplane VM IP, in order to allow using the kubeconfig inside the cluster
…-kubevirtci Change "kubevirtci create-cluster" command to use clusterkubevirtadm kubeconfig
…ns-v1 MachineHealthCheck and node remediation integration
- move all e2e code to e2e_test package - consolidate logic and reduce number of files - move required args validation to test suite initialization - extract tenant cluster kubernetes version to env var Signed-off-by: Alex Gradouski <[email protected]>
refactor e2e tests
…to_sync_upstream_2022-04-20-17-35
Signed-off-by: David Vossel <[email protected]>
…ream_2022-04-20-17-35 auto sync 2022-04-20-17-35
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@nunnatsa: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release notes: