Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7555: Add OpenShift Quickstart for JBoss EAP 8 #932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ODC-7555: Add OpenShift Quickstart for JBoss EAP 8 #932

wants to merge 1 commit into from

Conversation

jmesnil
Copy link
Contributor

@jmesnil jmesnil commented Sep 9, 2024 •
edited by openshift-ci bot
Loading

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2024 •
edited by openshift-ci bot
Loading

@jmesnil: This pull request references ODC-7555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2024 •
edited by openshift-ci bot
Loading

@jmesnil: This pull request references ODC-7555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmesnil
Copy link
Contributor Author

jmesnil commented Oct 4, 2024

/retest

@jhadvig
Copy link
Member

jhadvig commented Oct 4, 2024

/lgtm
/approve

@opayne1 could you please take a look at this QuickStart. :)

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2024
opayne1
opayne1 reviewed Oct 7, 2024
View reviewed changes
Copy link

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had a few comments.

quickstarts/jboss-eap8-with-helm.yaml Outdated Show resolved Hide resolved
quickstarts/jboss-eap8-with-helm.yaml Outdated

1. In the navigation menu, click [Topology]{{highlight qs-nav-topology}}.
In the Topology view, the **eap8** deployment displays a code icon in the bottom right-hand corner. This icon either represents the Git repository
of the associated code, or if the appropriate operators are installed, it will bring up the associated code in your IDE.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of the associated code, or if the appropriate operators are installed, it will bring up the associated code in your IDE.
of the associated code, or if the appropriate operators are installed, it will open the associated code in your IDE.

quickstarts/jboss-eap8-with-helm.yaml Outdated Show resolved Hide resolved
quickstarts/jboss-eap8-with-helm.yaml Outdated Show resolved Hide resolved
quickstarts/jboss-eap8-with-helm.yaml Outdated Show resolved Hide resolved
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2025
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2025
@jmesnil
Copy link
Contributor Author

jmesnil commented Feb 18, 2025

/retest-required

@jhadvig
Copy link
Member

jhadvig commented Feb 18, 2025

/lgtm cancel
@jmesnil could you please address first @opayne1 comments? Thank you :)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmesnil
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhadvig. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@jmesnil
ODC-7555: Add OpenShift Quickstart for JBoss EAP 8
829f308 
This OpenShift Quickstart is similar to the one for
JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Signed-off-by: Jeff Mesnil <[email protected]>
@jmesnil jmesnil force-pushed the ODC-7555_quickstart_jboss_eap8 branch from a3a4859 to 829f308 Compare February 18, 2025 11:59
@jmesnil
Copy link
Contributor Author

jmesnil commented Feb 18, 2025

@jhadvig Sorry, I forgot to push my amended commit. I've resolved all @opayne1 suggestions. thanks!

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@jmesnil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@opayne1
Copy link

opayne1 commented Feb 19, 2025

Thanks for the updates.

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opayne1 opayne1 opayne1 left review comments

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

Assignees

@jhadvig jhadvig

Labels
docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmesnil @openshift-ci-robot @jhadvig @openshift-bot @opayne1