Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7555: Add OpenShift Quickstart for JBoss EAP 8 #932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmesnil
Copy link
Contributor

@jmesnil jmesnil commented Sep 9, 2024

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

This OpenShift Quickstart is similar to the one for
JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Signed-off-by: Jeff Mesnil <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2024

@jmesnil: This pull request references ODC-7555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2024

@jmesnil: This pull request references ODC-7555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmesnil
Copy link
Contributor Author

jmesnil commented Oct 4, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@jmesnil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator a3a4859 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhadvig
Copy link
Member

jhadvig commented Oct 4, 2024

/lgtm
/approve

@opayne1 could you please take a look at this QuickStart. :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, jmesnil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
Copy link

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had a few comments.


With this quick start, you can deploy and run a [Jakarta EE application](https://github.com/jboss-eap-up-and-running/eap8-getting-started) with JBoss EAP 8 on OpenShift.

**Note:** The quickstart uses a sample [Jakarta EE application](https://github.com/jboss-eap-up-and-running/eap8-getting-started). You can deploy your own Jakarta EE 10 application using the same steps.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be something we have to address as a whole, but in docs we refer to quick starts in 2 words. I can't recall what we have in the console currently.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note:** The quickstart uses a sample [Jakarta EE application](https://github.com/jboss-eap-up-and-running/eap8-getting-started). You can deploy your own Jakarta EE 10 application using the same steps.
**Note:** The quick start uses a sample [Jakarta EE application](https://github.com/jboss-eap-up-and-running/eap8-getting-started). You can deploy your own Jakarta EE 10 application using the same steps.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you refer to it in two words elsewhere


1. In the navigation menu, click [Topology]{{highlight qs-nav-topology}}.
In the Topology view, the **eap8** deployment displays a code icon in the bottom right-hand corner. This icon either represents the Git repository
of the associated code, or if the appropriate operators are installed, it will bring up the associated code in your IDE.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of the associated code, or if the appropriate operators are installed, it will bring up the associated code in your IDE.
of the associated code, or if the appropriate operators are installed, it will open the associated code in your IDE.

- The first build configuration **eap8-build-artifacts** compiles and packages the Jakarta EE application, and creates a JBoss EAP server.
The application is run on this JBoss EAP server.

The build may take a few minutes to complete. The build state is indicated by a relevant message such as **Pending**, **Running**, and **Complete**.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The build may take a few minutes to complete. The build state is indicated by a relevant message such as **Pending**, **Running**, and **Complete**.
The build might take a few minutes to complete. The build state is indicated by a relevant message such as **Pending**, **Running**, and **Complete**.

review:
failedTaskHelp: This task isn’t verified yet. Try the task again.
instructions: >-
The two builds for **eap8-build-artifacts** and **eap8** may take a few minutes to complete.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The two builds for **eap8-build-artifacts** and **eap8** may take a few minutes to complete.
The two builds for **eap8-build-artifacts** and **eap8** might take a few minutes to complete.


To view the JBoss EAP application:

1. In the **Topology** view, click the external link icon in the top right-hand corner to open the URL and run the application in a separate browser window.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. In the **Topology** view, click the external link icon in the top right-hand corner to open the URL and run the application in a separate browser window.
1. In the **Topology** view, click the external link icon in the top right corner to open the URL and run the application in a separate browser window.

I will say that in docs we avoid directionals for accessibility reasons, but I would defiantly make it "right" instead of "right-hand" at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants