Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CONSOLE-4277: Console-operator should make use of the new downloads server #935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mylanos
Copy link

@Mylanos Mylanos commented Oct 9, 2024

Prepare the console-operator for new downloads server image, to be built from the openshift/console codebase (link) as part of release repository as soon the CONSOLE-4276 merges.

Setup the configuration of the artifacts to be stored in the ConfigMap as part of the CO repo and use it instead of the default artifactsConfiguration provided in console.

Tested it on my own image of the downloads-server instead of the image TO BE published in the release repo. At the moment I left the original image in place - Needs to be updated when CONSOLE-4276 merges.

On the following screenshot we can see the downloads-server pod running.
Screenshot 2024-10-09 at 16 46 21

Showcase of the pod being deployed with updated downloads-deployment, and artifacts download links.
https://github.com/user-attachments/assets/1fc9e023-32fa-4b38-8802-3599160ce4cd

…he configuration of the artifacts in a ConfigMap, fix unit tests
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2024

@Mylanos: This pull request references CONSOLE-4277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Prepare the console-operator for new downloads server image, to be built from the openshift/console codebase (link) an published as part of release repository as soon the CONSOLE-4276 merges.

Introduce the configuration of the artifacts to be stored in the ConfigMapas part of the CO repo and use it instead of the defaulyartifactsConfiguration` provided in console.

Tested it on my own image of the downloads-server, built from openshift/console instead of the image TO BE published in the release repo. At the moment I left the original images in place - Needs to be updated when CONSOLE-4276 merges.

On the following screenshot we can see the downloads-server pod running.
Screenshot 2024-10-09 at 16 46 21

Showcase of the pod being deployed with updated downloads-deployment, and artifacts download links.
https://github.com/user-attachments/assets/1fc9e023-32fa-4b38-8802-3599160ce4cd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2024

@Mylanos: This pull request references CONSOLE-4277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Prepare the console-operator for new downloads server image, to be built from the openshift/console codebase (link) an published as part of release repository as soon the CONSOLE-4276 merges.

Introduce the configuration of the artifacts to be stored in the ConfigMap as part of the CO repo and use it instead of the defauly artifactsConfiguration provided in console.

Tested it on my own image of the downloads-server, built from openshift/console instead of the image TO BE published in the release repo. At the moment I left the original images in place - Needs to be updated when CONSOLE-4276 merges.

On the following screenshot we can see the downloads-server pod running.
Screenshot 2024-10-09 at 16 46 21

Showcase of the pod being deployed with updated downloads-deployment, and artifacts download links.
https://github.com/user-attachments/assets/1fc9e023-32fa-4b38-8802-3599160ce4cd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mylanos
Once this PR has been reviewed and has the lgtm label, please assign therealjon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2024

@Mylanos: This pull request references CONSOLE-4277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Prepare the console-operator for new downloads server image, to be built from the openshift/console codebase (link) as part of release repository as soon the CONSOLE-4276 merges.

Setup the configuration of the artifacts to be stored in the ConfigMap as part of the CO repo and use it instead of the default artifactsConfiguration provided in console.

Tested it on my own image of the downloads-server instead of the image TO BE published in the release repo. At the moment I left the original image in place - Needs to be updated when CONSOLE-4276 merges.

On the following screenshot we can see the downloads-server pod running.
Screenshot 2024-10-09 at 16 46 21

Showcase of the pod being deployed with updated downloads-deployment, and artifacts download links.
https://github.com/user-attachments/assets/1fc9e023-32fa-4b38-8802-3599160ce4cd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

@Mylanos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 1eba0c8 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-single-node 1eba0c8 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-azure-ovn-upgrade 1eba0c8 link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants