-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CONSOLE-4277: Console-operator should make use of the new downloads server #935
base: master
Are you sure you want to change the base?
Conversation
…he configuration of the artifacts in a ConfigMap, fix unit tests
@Mylanos: This pull request references CONSOLE-4277 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Mylanos: This pull request references CONSOLE-4277 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mylanos The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Mylanos: This pull request references CONSOLE-4277 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Mylanos: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Prepare the console-operator for new downloads server image, to be built from the
openshift/console
codebase (link) as part of release repository as soon the CONSOLE-4276 merges.Setup the configuration of the artifacts to be stored in the
ConfigMap
as part of the CO repo and use it instead of the defaultartifactsConfiguration
provided in console.Tested it on my own image of the downloads-server instead of the image TO BE published in the release repo. At the moment I left the original image in place - Needs to be updated when CONSOLE-4276 merges.
On the following screenshot we can see the downloads-server pod running.
Showcase of the pod being deployed with updated downloads-deployment, and artifacts download links.
https://github.com/user-attachments/assets/1fc9e023-32fa-4b38-8802-3599160ce4cd