OCPBUGS-44556: console/status: set initial value of Message field

[liouk]

Due to this change, the condition's Message field has now a zero value of nil (due to using the ConditionApplyConfiguration), while before it was simply "", which is a valid value for Message.

This PR simply initializes the Message field to an empty string.

[openshift-ci-robot]

@liouk: This pull request references Jira Issue OCPBUGS-44556, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Due to this change, the condition's Message field has now a zero value of nil (due to using the ConditionApplyConfiguration), while before it was simply "", which is a valid value for Message.

This PR simply initializes the Message field to an empty string.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[liouk]

/jira refresh

[openshift-ci-robot]

@liouk: This pull request references Jira Issue OCPBUGS-44556, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[liouk]

/retest-required

[spadgett]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liouk, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[liouk]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 570755c and 2 for PR HEAD 4b0b176 in total

[openshift-ci]

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@liouk: Jira Issue OCPBUGS-44556: All pull requests linked via external trackers have merged:

• openshift/console-operator#940

Jira Issue OCPBUGS-44556 has been moved to the MODIFIED state.

In response to this:

Due to this change, the condition's Message field has now a zero value of nil (due to using the ConditionApplyConfiguration), while before it was simply "", which is a valid value for Message.

This PR simply initializes the Message field to an empty string.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.19.0-202412011339.p0.gcc940ea.assembly.stream.el9.
All builds following this will include this PR.

[xingxingxia]

/jira backport release-4.18
For 4.17 and 4.16, I guess HCP has same issue, will confirm and backport later.

[xingxingxia]

Seems /jira backport does not work. Will manually create backport bug if needed.
/cherry-pick release-4.18

[openshift-cherrypick-robot]

@xingxingxia: new pull request created: #941

In response to this:

Seems /jira backport does not work. Will manually create backport bug if needed.
/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xingxingxia]

For 4.17 and 4.16, I guess HCP has same issue, will confirm and backport later.

Tested 4.16.0-0.nightly-2024-12-02-183536 HCP BYO, it doesn't have the issue related to this PR. But it has the "OIDC provider CA version not up to date in current deployment" and "status: Unknown" issue. Create a 4.18/4.19 bug https://issues.redhat.com/browse/OCPBUGS-45300 and added 4.16 under its Version-Release number of selected component field.

Tested 4.17.0-0.nightly-2024-12-02-175016 HCP BYO, it has the issue of this PR:

 oc get co console
NAME      VERSION                              AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
console   4.17.0-0.nightly-2024-12-02-175016   True        False         True       170m    AuthStatusHandlerDegraded: Authentication.config.openshift.io "cluster" is invalid: [oidcClients[1].conditions[2].message: Required value, <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]

So cherry-picking to 4.17 too (but I'll modify its bug description for HCP BYO):
/cherry-pick release-4.17

[openshift-cherrypick-robot]

@xingxingxia: new pull request created: #943

In response to this:

For 4.17 and 4.16, I guess HCP has same issue, will confirm and backport later.

Tested 4.16.0-0.nightly-2024-12-02-183536 HCP BYO, it doesn't have the issue related to this PR. But it has the "OIDC provider CA version not up to date in current deployment" and "status: Unknown" issue. Create a 4.18/4.19 bug https://issues.redhat.com/browse/OCPBUGS-45300 and added 4.16 under its Version-Release number of selected component field.

Tested 4.17.0-0.nightly-2024-12-02-175016 HCP BYO, it has the issue of this PR:

oc get co console
NAME      VERSION                              AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
console   4.17.0-0.nightly-2024-12-02-175016   True        False         True       170m    AuthStatusHandlerDegraded: Authentication.config.openshift.io "cluster" is invalid: [oidcClients[1].conditions[2].message: Required value, <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]

So cherry-picking to 4.17 too (but I'll modify its bug description for HCP BYO):
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.