Upgrade admissionreview to v1 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @deads2k |
|
we should support both, but only advertise v1. This will allow an orderly transition so the admission webhook configuration can change at our leisure. |
qiujian16
force-pushed
the
update-admission-v1
branch
2 times, most recently
from
e4ebc43
to
316d233
Compare
|
/lgtm Do you happen to have a proof PR showing this in action? |
qiujian16
force-pushed
the
update-admission-v1
branch
from
316d233
to
49ee199
Compare
qiujian16
force-pushed
the
update-admission-v1
branch
from
49ee199
to
dd5889c
Compare
qiujian16
force-pushed
the
update-admission-v1
branch
from
dd5889c
to
416f859
Compare
|
this pr is for proof https://github.com/open-cluster-management/registration/pull/139. I copy uid from request to response here for v1 https://github.com/openshift/generic-admission-server/pull/41/files#diff-fd8ab7084521a011bc46ae5a8d595653bb6235a4102d5de2226b707264c43145R45 |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.