-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-2777: Implement hive Nutanix provisioning #2573
base: master
Are you sure you want to change the base?
HIVE-2777: Implement hive Nutanix provisioning #2573
Conversation
@eliorerz: This pull request references HIVE-2777 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
@eliorerz: GitHub didn't allow me to request PR reviews from the following users: eliorerz. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dc89df3
to
c68f669
Compare
@eliorerz: This pull request references HIVE-2777 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @2uasimojo |
@eliorerz: This pull request references HIVE-2777 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eliorerz: This pull request references HIVE-2777 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Going to get started on this. One question about the install-config: I noticed the prismElements and subnetUUIDs are duplicated at the top level and under failureDomains. We talked yesterday about the ClusterDeployment.Spec.Platform.Nutanix schema not containing this redundancy. I assume it's still supported via install-config, but it's not necessary, right? IOW your PoC still works if you omit the top-level copy? |
Thanks, Regarding your question, the problem is that |
/test e2e e2e-pool Weird flakery probably due to some upstream bug that seems to be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! With a couple of minor tweaks, I think it's ready to go. (Except that, as we discussed, we're going to need to clone the appropriate install-config fields into cd.Spec.Platform.Nutanix in anticipation of MachinePools before we can actually "release" :( )
Reminders:
- We're going to need doc updates.
- Let's not forget to look into ClusterPools (will probably need to use Inventory). Note that the work required for ClusterPools overlaps quite a bit with that needed for
hiveutil create-cluster
, although the latter is optional as we've discussed.
pkg/controller/clusterdeployment/installconfigvalidation_test.go
Outdated
Show resolved
Hide resolved
pkg/validating-webhooks/hive/v1/clusterdeployment_validating_admission_hook_test.go
Show resolved
Hide resolved
c68f669
to
c092981
Compare
c092981
to
c17e725
Compare
bd300f9
to
3908c64
Compare
b9b80e8
to
66218d8
Compare
Add Nutanix deprovisioning support.
…e use of MachinePools for the Nutanix provider
@eliorerz: This pull request references HIVE-2777 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
815fb16
to
62a98fc
Compare
@eliorerz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is a partial implementation of #2550 PR, the final code will (probably) extend
ClusterDeployment
CR and will add support withMachinePools
.This PR adds support for provisioning OpenShift clusters on Nutanix using the OpenShift Installer's IPI installation method within Hive.
Key changes include:
install-config
nutanix platform credentials from secretnutanix-creds
(seepasteInProviderCredentials
method)Implementation:
Secrets