Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-39004: UPSTREAM: 126994: Add required FieldManager for validatingadmissionpolicy e2e #2069

Conversation

dgoodwin
Copy link

This line would fail if the code path happened to execute, which may not
happen in upstream, but does trigger occasionally in OpenShift testing.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 29, 2024
@openshift-ci-robot
Copy link

@dgoodwin: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@dgoodwin dgoodwin changed the title UPSTREAM: 126994 Add required FieldManager for validatingadmissionpolicy e2e OCPBUGS-39004: UPSTREAM: 126994 Add required FieldManager for validatingadmissionpolicy e2e Aug 29, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 29, 2024
@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-39004, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This line would fail if the code path happened to execute, which may not
happen in upstream, but does trigger occasionally in OpenShift testing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 29, 2024
@dgoodwin
Copy link
Author

/jira refresh

@openshift-ci openshift-ci bot requested review from deads2k and tkashem August 29, 2024 15:08
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 29, 2024
@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-39004, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 29, 2024
@openshift-ci openshift-ci bot requested a review from wangke19 August 29, 2024 15:09
@dgoodwin
Copy link
Author

/cherry-pick release-4.17

@openshift-cherrypick-robot

@dgoodwin: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kannon92
Copy link

/test verify-commits

…licy e2e

This line would fail if the code path happened to execute, which may not
happen in upstream, but does trigger occasionally in OpenShift testing.
@dgoodwin dgoodwin force-pushed the validating-admission-fieldmanager branch from 790f4dd to eb80296 Compare August 29, 2024 16:43
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Aug 29, 2024
@openshift-ci-robot
Copy link

@dgoodwin: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@dgoodwin dgoodwin changed the title OCPBUGS-39004: UPSTREAM: 126994 Add required FieldManager for validatingadmissionpolicy e2e OCPBUGS-39004: UPSTREAM: 126994: Add required FieldManager for validatingadmissionpolicy e2e Aug 29, 2024
Copy link

openshift-ci bot commented Aug 29, 2024

@dgoodwin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd eb80296 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tkashem
Copy link

tkashem commented Aug 30, 2024

/lgtm
/approve

cc @bertinatto
/hold
(feel free to cancel if there is no conflict with the rebase)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
Copy link

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@atiratree
Copy link
Member

no conflict, we can pick this
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8188633 and 2 for PR HEAD eb80296 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 191249b into openshift:master Aug 30, 2024
19 of 20 checks passed
@openshift-ci-robot
Copy link

@dgoodwin: Jira Issue OCPBUGS-39004: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39004 has been moved to the MODIFIED state.

In response to this:

This line would fail if the code path happened to execute, which may not
happen in upstream, but does trigger occasionally in OpenShift testing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@dgoodwin: new pull request created: #2070

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.18.0-202408310210.p0.g191249b.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.18.0-202408310210.p0.g191249b.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.18.0-202408310210.p0.g191249b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants