Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Make node ready only after static pods are registered #2078

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Make node ready only after static pods are registered #2078

wants to merge 2 commits into from

Commits on Oct 3, 2024

  1. Make node ready only after static pods are registered 

    Node registration and pod syncs are done in separate Go routines,
leading to a potential race condition. Static Pods might not get
registered because the kubelet is not registered, causing scheduler to
overcommit the node due to unawareness of static pod resource usage.
This resulted in kubelet rejecting pods due to insufficient resources.

The initial fix involved making the node schedulable only after static
pod registration, but this introduced a 1-1.5 minute latency due to
kubelet's resync interval for pods.

To address this latency, we now resync static pods immediately upon node
registration, ensuring the node becomes ready without additional delay.
    @AnishShah @haircommander
    AnishShah authored and haircommander committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5c45f28 View commit details
    Browse the repository at this point in the history

  2. refactor static pod registration code

    @AnishShah @haircommander
    AnishShah authored and haircommander committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bd429bf View commit details
    Browse the repository at this point in the history