UPSTREAM: <carry>: add audit annotations to track etcd state

[deads2k]

We can use these annotations in a monitortest to start counting how many seconds we appear to lose etcd leadership for and what percentage of etcd requests fail during that time.

[openshift-ci-robot]

@deads2k: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• cccaf3c|UPSTREAM: : add audit annotations to track etcd state: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[deads2k]

very strange

/retest

[openshift-ci-robot]

@deads2k: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 25a7459|UPSTREAM: : always track latencies: does not specify an upstream backport in the commit message
• bc8ac76|UPSTREAM: : add audit annotations to track etcd state: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[benluddy]

/lgtm

Discussed and accepted the increase in the serialized size of audit log entries in exchange for having the latency annotations all the time.

/hold

for proof

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

/hold

No "no leader" annotations in the audit, but clients definitely say they appeared. Who's lying! I'll check in the morning

[openshift-ci]

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-serial	bc8ac76	link	true	/test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-hypershift	bc8ac76	link	true	/test e2e-aws-ovn-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.