OCPBUGS-46038: UPSTREAM: 129180: prevent unnecessary resolving of iscsi/fc devices to dm

[RomanBednar]

No description provided.

[openshift-ci-robot]

@RomanBednar: This pull request references Jira Issue OCPBUGS-46038, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@RomanBednar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• f15af40|prevent unnecessary resolving of iscsi/fc devices to dm: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@RomanBednar: the contents of this pull request could be automatically validated.

The following commits are valid:

• 0943016|UPSTREAM: 129180: prevent unnecessary resolving of iscsi/fc devices to dm: the upstream PR kubernetes/kubernetes#129180 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[RomanBednar]

/jira refresh

[openshift-ci-robot]

@RomanBednar: This pull request references Jira Issue OCPBUGS-46038, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[RomanBednar]

/retest-required

[jsafrane]

Since it has been cherry-picked into 1.32.something upstream, we can also wait until it gets merged into OCP via periodic updates. Of course, it depends on how fast we need the fix in OCP - waiting for the next periodic update will take quite some time.

[RomanBednar]

Good point, I've considered that actually. But the fix should be backported into 4.15, and upstream PR (1.27) got rejected because that's out of support already. Looking at other PRs here it seems like we do backports in o/k to "our supported branches" regardless of upstream sometimes so I'd be cherrypicking into 4.15 manually anyway. Maybe there's a better way to do it?

cc @reivaj84 - do we need this fast or can we wait for the periodic update?

[reivaj84]

@RomanBednar @jsafrane we will need this fast IMO.

We have a customer that's suffering this issue and cannot workaround the problem by using the targetWWNs and lun number because they have a large amount of LUNs that maps to higher than 255 and they are limited because of https://issues.redhat.com/browse/OCPBUGS-46038

[RomanBednar]

/retest-required

[jsafrane]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane, RomanBednar
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RomanBednar]

/retest-required

[RomanBednar]

/label acknowledge-critical-fixes-only

[RomanBednar]

cc @bertinatto for approval

[openshift-ci]

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/k8s-e2e-aws-ovn-serial	0943016	link	false	/test k8s-e2e-aws-ovn-serial
ci/prow/e2e-aws-csi	0943016	link	false	/test e2e-aws-csi
ci/prow/e2e-agnostic-ovn-cmd	0943016	link	false	/test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[RomanBednar]

/retest-required