-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add NAC restore controller objects #1388
base: master
Are you sure you want to change the base?
feat: Add NAC restore controller objects #1388
Conversation
Signed-off-by: Mateus Oliveira <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mateus Oliveira <[email protected]>
@@ -422,6 +441,9 @@ spec: | |||
kind: NonAdminBackup | |||
name: nonadminbackups.nac.oadp.openshift.io | |||
version: v1alpha1 | |||
- kind: NonAdminRestore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO do not forget to add description
@mateusoliveira43: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/lifecycle frozen |
@mateusoliveira43: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/remove-lifecycle stale |
Why the changes were made
Integrate NAC restore controller objects to OADP. Related work migtools/oadp-non-admin#42
How the changes were made
Run
make update-non-admin-manifests
pointing to related PR branch.How to test the changes made
TODO