fix: Remove indirect import of AWS package #1585
Merged
+67
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateus Oliveira <[email protected]>
openshift-ci
bot
added
the
approved
shubham-pampattiwar
approved these changes
Nov 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kaovilai
reviewed
Nov 8, 2024
There was a problem hiding this comment.
validated in codespaces
@kaovilai ➜ /workspaces/oadp-operator (fix/remove-indirect-aws-import) $ go list --deps ./pkg/common
internal/goarch
unsafe
internal/abi
internal/unsafeheader
internal/cpu
internal/bytealg
internal/byteorder
internal/chacha8rand
internal/coverage/rtcov
internal/godebugs
internal/goexperiment
internal/goos
internal/profilerecord
internal/runtime/atomic
internal/runtime/exithook
internal/runtime/syscall
internal/stringslite
runtime/internal/math
runtime/internal/sys
runtime
internal/reflectlite
errors
cmp
internal/itoa
internal/race
iter
math/bits
math
unicode/utf8
strconv
sync/atomic
sync
unicode
reflect
slices
internal/fmtsort
io
internal/oserror
path
internal/bisect
internal/godebug
internal/asan
internal/msan
syscall
time
io/fs
internal/filepathlite
internal/syscall/unix
internal/poll
internal/syscall/execenv
internal/testlog
os
fmt
strings
github.com/vmware-tanzu/velero/pkg/types
bytes
bufio
encoding
encoding/binary
encoding/base64
unicode/utf16
encoding/json
log/internal
log
sort
github.com/gogo/protobuf/proto
github.com/gogo/protobuf/sortkeys
math/rand
math/big
gopkg.in/inf.v0
k8s.io/apimachinery/pkg/api/resource
github.com/google/gofuzz/bytesource
regexp/syntax
regexp
github.com/google/gofuzz
k8s.io/apimachinery/third_party/forked/golang/reflect
k8s.io/apimachinery/pkg/conversion
k8s.io/apimachinery/pkg/selection
k8s.io/apimachinery/pkg/fields
k8s.io/apimachinery/pkg/util/sets
k8s.io/apimachinery/pkg/util/errors
k8s.io/apimachinery/pkg/util/validation/field
context
vendor/golang.org/x/net/dns/dnsmessage
internal/nettrace
internal/singleflight
math/rand/v2
internal/concurrent
internal/weak
unique
net/netip
runtime/cgo
net
k8s.io/utils/internal/third_party/forked/golang/net
k8s.io/utils/net
k8s.io/apimachinery/pkg/util/validation
flag
log/slog/internal
log/slog/internal/buffer
log/slog
github.com/go-logr/logr
github.com/go-logr/logr/slogr
k8s.io/klog/v2/internal/severity
k8s.io/klog/v2/internal/buffer
k8s.io/klog/v2/internal/clock
k8s.io/klog/v2/internal/dbg
k8s.io/klog/v2/internal/serialize
k8s.io/klog/v2/internal/sloghandler
os/user
path/filepath
k8s.io/klog/v2
k8s.io/utils/strings/slices
k8s.io/apimachinery/pkg/labels
go/token
go/scanner
go/ast
go/doc/comment
internal/lazyregexp
go/doc
go/build/constraint
go/internal/typeparams
go/parser
net/url
k8s.io/apimachinery/pkg/conversion/queryparams
k8s.io/apimachinery/pkg/runtime/schema
sigs.k8s.io/json/internal/golang/encoding/json
sigs.k8s.io/json
k8s.io/apimachinery/pkg/util/json
runtime/debug
k8s.io/apimachinery/pkg/util/naming
compress/flate
hash
hash/crc32
compress/gzip
container/list
crypto
crypto/internal/alias
crypto/subtle
crypto/cipher
crypto/internal/boring/sig
crypto/internal/boring
crypto/internal/randutil
crypto/rand
crypto/aes
crypto/des
crypto/internal/edwards25519/field
crypto/internal/nistec/fiat
embed
crypto/internal/nistec
crypto/ecdh
crypto/elliptic
crypto/internal/bigmod
crypto/internal/boring/bbig
crypto/sha512
encoding/asn1
vendor/golang.org/x/crypto/cryptobyte/asn1
vendor/golang.org/x/crypto/cryptobyte
crypto/ecdsa
crypto/internal/edwards25519
crypto/ed25519
crypto/hmac
vendor/golang.org/x/crypto/internal/alias
vendor/golang.org/x/crypto/chacha20
vendor/golang.org/x/crypto/internal/poly1305
vendor/golang.org/x/sys/cpu
vendor/golang.org/x/crypto/chacha20poly1305
vendor/golang.org/x/crypto/hkdf
crypto/internal/hpke
vendor/golang.org/x/crypto/sha3
crypto/internal/mlkem768
crypto/md5
crypto/rc4
crypto/rsa
crypto/sha1
crypto/sha256
crypto/dsa
encoding/hex
crypto/x509/pkix
encoding/pem
crypto/x509
crypto/tls
vendor/golang.org/x/text/transform
vendor/golang.org/x/text/unicode/bidi
vendor/golang.org/x/text/secure/bidirule
vendor/golang.org/x/text/unicode/norm
vendor/golang.org/x/net/idna
net/textproto
vendor/golang.org/x/net/http/httpguts
vendor/golang.org/x/net/http/httpproxy
vendor/golang.org/x/net/http2/hpack
maps
mime
mime/quotedprintable
mime/multipart
net/http/httptrace
net/http/internal
net/http/internal/ascii
net/http
k8s.io/apimachinery/pkg/util/runtime
io/ioutil
github.com/modern-go/concurrent
github.com/modern-go/reflect2
github.com/json-iterator/go
gopkg.in/yaml.v2
sigs.k8s.io/structured-merge-diff/v4/value
k8s.io/apimachinery/pkg/runtime
k8s.io/apimachinery/pkg/types
k8s.io/apimachinery/pkg/util/intstr
golang.org/x/text/transform
golang.org/x/text/unicode/bidi
golang.org/x/text/secure/bidirule
golang.org/x/text/unicode/norm
golang.org/x/net/idna
golang.org/x/net/http/httpguts
golang.org/x/net/http2/hpack
golang.org/x/net/http2
k8s.io/apimachinery/pkg/util/net
k8s.io/apimachinery/pkg/watch
k8s.io/apimachinery/pkg/apis/meta/v1
k8s.io/api/core/v1
github.com/openshift/oadp-operator/pkg/common
@kaovilai ➜ /workspaces/oadp-operator (fix/remove-indirect-aws-import) $ go list --deps ./pkg/common | grep aws
@kaovilai ➜ /workspaces/oadp-operator (fix/remove-indirect-aws-import) $ 
|
/lgtm |
|
/test 4.15-e2e-test-aws |
2 similar comments
|
/retest-required |
|
/override ci/prow/4.17-e2e-test-kubevirt-aws |
|
Waiting for volume binding |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.17-e2e-test-kubevirt-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mateusoliveira43: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes were made
While working on migtools/oadp-non-admin#37, I will need to add
oadp-operatoras a import inoadp-non-admin. In my first test, while I just need to importapi/v1alpha1, I noticedgithub.com/aws/aws-sdk-gowas being added tooadp-non-admin'sgo.mod. On inspecting I saw this:This PR removes
github.com/aws/aws-sdk-gofrompkg/commonHow to test the changes made
Check that this change did not break any part.