Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS#4112[OPECO][4.14] Multi-arch support for Operator projects #64355

Merged
merged 1 commit into from
Oct 9, 2023
Merged

OSDOCS#4112[OPECO][4.14] Multi-arch support for Operator projects #64355

merged 1 commit into from
Oct 9, 2023

Conversation

michaelryanpeter
Copy link
Contributor

@michaelryanpeter michaelryanpeter commented Sep 5, 2023 •
edited
Loading

Version(s): 4.14

Issue: OSDOCS-4112

Link to docs preview: Configuring Operator projects to support multiple architectures and operating systems

QE review:

  • QE has approved this change.

Additional information:

@michaelryanpeter michaelryanpeter added this to the Planned for 4.14 GA milestone Sep 5, 2023
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 5, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://64355--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27183

jaypoulz
jaypoulz reviewed Sep 8, 2023
View reviewed changes
Copy link

@jaypoulz jaypoulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so I've left comments on the overall skeleton and provided extra context where I could.

Overall, this is already looking very good. I didn't have a chance to run through it with an example operator, but I will try to get to that early next week.

modules/osdk-multi-arch-node-affinity.adoc Outdated Show resolved Hide resolved
aleskandro
aleskandro reviewed Sep 13, 2023
View reviewed changes
modules/osdk-multi-arch-node-affinity.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-node-affinity.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-node-affinity.adoc Outdated Show resolved Hide resolved
@michaelryanpeter
Copy link
Contributor Author

@aleskandro and @jaypoulz I'm sorry for not responding to all of your feedback yet. I had some bugs come up that needed to be addressed. I have also needed to process some of the comments to adjust the information architecture of the content. I will reach out if I get blocked on anything. Thanks for your help!

@michaelryanpeter michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 3 times, most recently from 53531f9 to 3e15a33 Compare September 28, 2023 23:12
jaypoulz
jaypoulz suggested changes Sep 29, 2023
View reviewed changes
Copy link

@jaypoulz jaypoulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is still in progress. I will pick up where I left off starting with the changes in osdk-multi-arch-node-affinity.adoc

modules/osdk-multi-arch-building-images.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-building-manifest-list.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-building-manifest-list.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-building-manifest-list.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-inspect-image-manifest.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-inspect-image-manifest.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-inspect-image-manifest.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-inspect-image-manifest.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-inspect-image-manifest.adoc Outdated Show resolved Hide resolved
@michaelryanpeter michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 2 times, most recently from 28ae7e5 to 456179e Compare September 29, 2023 23:47
@michaelryanpeter
Copy link
Contributor Author

michaelryanpeter commented Sep 29, 2023 •
edited
Loading

@jaypoulz and @everettraven I have reorganized the content based on both of your comments.

In particular, I simplified the procedure for making a manifest list, removing the steps where I unintentionally repeated myself. I removed the skopeo related content, as well. Since the Operator SDK uses docker buildx, it seemed distracting to bounce between tools.

I also moved the validation procedure to the Bundle validate section of the docs. Lastly, I decided to link out to the procedure on adding labels to the Operator's CSV. That module needs to be rewritten to conform with this new content, and I am not going to be able to get to that before GA.

@aleskandro
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 3, 2023
@michaelryanpeter michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 3 times, most recently from 6cda9df to 78057f6 Compare October 3, 2023 17:24
@michaelryanpeter michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 2 times, most recently from d0e842f to 3f60cdc Compare October 5, 2023 16:54
jaypoulz
jaypoulz approved these changes Oct 5, 2023
View reviewed changes
Copy link

@jaypoulz jaypoulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2023

New changes are detected. LGTM label has been removed.

@michaelryanpeter
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 6, 2023
@skopacz1
Copy link
Contributor

skopacz1 commented Oct 6, 2023

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 6, 2023
skopacz1
skopacz1 reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but looks good to me!

modules/olm-enabling-operator-for-multi-arch.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-building-images.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-building-images.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-building-images.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-building-images.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-node-reqs.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-node-reqs.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-node-reqs.adoc Show resolved Hide resolved
modules/osdk-multi-arch-node-reqs.adoc Show resolved Hide resolved
modules/osdk-multi-arch-validate.adoc Outdated Show resolved Hide resolved
@skopacz1
Copy link
Contributor

skopacz1 commented Oct 6, 2023

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 6, 2023
@michaelryanpeter michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 3 times, most recently from e179c5d to 1da00a6 Compare October 6, 2023 16:45
skopacz1
skopacz1 reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, let me know what you think!

modules/osdk-multi-arch-building-images.adoc Show resolved Hide resolved
modules/osdk-multi-arch-building-images.adoc Show resolved Hide resolved
modules/osdk-multi-arch-building-images.adoc Show resolved Hide resolved
modules/osdk-multi-arch-building-images.adoc Outdated Show resolved Hide resolved
modules/osdk-multi-arch-building-images.adoc Outdated Show resolved Hide resolved
@michaelryanpeter michaelryanpeter merged commit 4407caf into openshift:main Oct 9, 2023
1 check passed
@michaelryanpeter
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2023
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #65961

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelryanpeter michaelryanpeter deleted the opeco-4.14-mixed-arch branch October 26, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skopacz1 skopacz1 skopacz1 left review comments

@everettraven everettraven everettraven left review comments

@aleskandro aleskandro aleskandro left review comments

@Prashanth684 Prashanth684 Prashanth684 left review comments

@jaypoulz jaypoulz jaypoulz approved these changes

Assignees

@jaypoulz jaypoulz

Labels
branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.14 GA
Development

Successfully merging this pull request may close these issues.
8 participants
@michaelryanpeter @ocpdocs-previewbot @aleskandro @skopacz1 @openshift-cherrypick-robot @jaypoulz @Prashanth684 @everettraven