Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira OCPBUGS-38888: Align RDS SCTP module with documentation #80850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreaskaris
Copy link

@andreaskaris andreaskaris commented Aug 23, 2024

Version(s):

Issue:
Reported-at: #80849

Link to docs preview:
https://80850--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco_ref_design_specs/core/telco-core-ref-crs#telco-core-sctp_module_mc-yaml

QE review:

  • QE has approved this change.

Additional information:

The fields are in slightly different order from the documentation snippet as I aligned them with the output that one would get from OpenShift (to make a diff with life documentation easier, this is the canonical format for the RDS files as far as I can tell):

# oc get mc load-sctp-module -o yaml
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
(...)
  labels:
    machineconfiguration.openshift.io/role: worker
  name: load-sctp-module
(...)
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      files:
      - contents:
          source: data:,
        mode: 420
        overwrite: true
        path: /etc/modprobe.d/sctp-blacklist.conf
      - contents:
          source: data:,sctp
        mode: 420
        overwrite: true
        path: /etc/modules-load.d/sctp-load.conf

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2024
@andreaskaris
Copy link
Author

@openshift/team-documentation
@imiller0

@andreaskaris andreaskaris changed the title Align RDS SCTP module with documentation Jira OCPBUGS-38888: Align RDS SCTP module with documentation Aug 23, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 23, 2024
@openshift-ci-robot
Copy link

@andreaskaris: This pull request references Jira Issue OCPBUGS-38888, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reported-at: #80849

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

The fields are in slightly different order from the documentation snippet as I aligned them with the output that one would get from OpenShift (to make a diff with life documentation easier, this is the canonical format for the RDS files as far as I can tell):

# oc get mc load-sctp-module -o yaml
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
(...)
 labels:
   machineconfiguration.openshift.io/role: worker
 name: load-sctp-module
(...)
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:,
       mode: 420
       overwrite: true
       path: /etc/modprobe.d/sctp-blacklist.conf
     - contents:
         source: data:,sctp
       mode: 420
       overwrite: true
       path: /etc/modules-load.d/sctp-load.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andreaskaris
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 23, 2024
@openshift-ci-robot
Copy link

@andreaskaris: This pull request references Jira Issue OCPBUGS-38888, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

🤖 Fri Aug 23 11:48:26 - Prow CI generated the docs preview:

https://80850--ocpdocs-pr.netlify.app/

Copy link

openshift-ci bot commented Aug 23, 2024

@andreaskaris: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@andreaskaris: This pull request references Jira Issue OCPBUGS-38888, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Reported-at: #80849

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

The fields are in slightly different order from the documentation snippet as I aligned them with the output that one would get from OpenShift (to make a diff with life documentation easier, this is the canonical format for the RDS files as far as I can tell):

# oc get mc load-sctp-module -o yaml
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
(...)
 labels:
   machineconfiguration.openshift.io/role: worker
 name: load-sctp-module
(...)
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:,
       mode: 420
       overwrite: true
       path: /etc/modprobe.d/sctp-blacklist.conf
     - contents:
         source: data:,sctp
       mode: 420
       overwrite: true
       path: /etc/modules-load.d/sctp-load.conf

Preview link:
https://80850--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco_ref_design_specs/core/telco-core-ref-crs#telco-core-sctp_module_mc-yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Aug 26, 2024
@ShaunaDiaz
Copy link
Contributor

@andreaskaris What versions of the docs does this fix apply to? I have also requested a review from a member of the Telco docs team, who can help with additional QE or SME reviews needed.

@andreaskaris
Copy link
Author

It should go to latest all the way down to OCP 4.14

@andreaskaris
Copy link
Author

@imiller0 might want to have a look

@imiller0
Copy link

imiller0 commented Aug 26, 2024

We need to update the actual reference configuration here first and then pull that into the docs.
cc: @aireilly

@aireilly
Copy link
Contributor

Let's update the docs when the YAML is available in the ztp-site-generate container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants