Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass applicable environment flags to the external binary #29506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smg247
Copy link
Member

@smg247 smg247 commented Jan 30, 2025

The values for these flags are determined by inspecting the cluster.

This is an initial, non-exhaustive PR.
I will follow this up by adding a couple of additional flags to OTE for -external-connectivity and --optional-capability, and then passing their respective values. I will also remove the --installer flag, as we don't have a use for it yet.

There will also be an additional PR to translate the current test skips in openshift/kubernetes to utilize these flags instead.

For: https://issues.redhat.com/browse/TRT-1853

…for these flags are determined by inspecting the cluster
@smg247
Copy link
Member Author

smg247 commented Jan 30, 2025

/cc @stbenjam

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smg247
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@smg247: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn f8fdca6 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-microshift f8fdca6 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-hypershift-conformance f8fdca6 link false /test e2e-hypershift-conformance
ci/prow/e2e-aws-ovn-cgroupsv2 f8fdca6 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node-upgrade f8fdca6 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-edge-zones f8fdca6 link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-microshift-serial f8fdca6 link true /test e2e-aws-ovn-microshift-serial
ci/prow/okd-scos-e2e-aws-ovn f8fdca6 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node-serial f8fdca6 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node f8fdca6 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-upgrade f8fdca6 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout f8fdca6 link false /test e2e-aws-ovn-kube-apiserver-rollout

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant