Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FLs and TLs as approvers #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add FLs and TLs as approvers #186

wants to merge 1 commit into from
+2 −0

Conversation

mmazur
Copy link
Member

@mmazur mmazur commented Nov 5, 2024

Make FLs and TLs approvers for cases where standard approvers aren't suitable/are hard to reach.

Ref OSD-25197

@openshift-ci openshift-ci bot requested review from bmeng and rendhalver November 5, 2024 12:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.54%. Comparing base (e623f89) to head (13ea758).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   46.54%   46.54%           
=======================================
  Files           9        9           
  Lines         752      752           
=======================================
  Hits          350      350           
  Misses        392      392           
  Partials       10       10

@ravitri
Copy link
Member

ravitri commented Nov 8, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmazur, ravitri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@ravitri
Copy link
Member

ravitri commented Nov 8, 2024

The validate test would pass once #187 is merged

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

18 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

5 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@bmeng
Copy link
Contributor

bmeng commented Nov 27, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

19 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9735c57 and 2 for PR HEAD 13ea758 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@mmazur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 13ea758 link true /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mmazur
Copy link
Member Author

mmazur commented Nov 28, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeng bmeng Awaiting requested review from bmeng

@rendhalver rendhalver Awaiting requested review from rendhalver

Assignees

@ravitri ravitri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmazur @codecov-commenter @ravitri @openshift-ci-robot @bmeng