Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bp update #193

Merged
merged 1 commit into from
Feb 26, 2025
Merged

make bp update #193

merged 1 commit into from
Feb 26, 2025

Conversation

ritmun
Copy link
Contributor

@ritmun ritmun commented Feb 26, 2025

What type of PR is this?

(bug/feature/cleanup/documentation/test/refactor)

boilerplate update

What this PR does / why we need it?

includes sdcicd-1414 to move e2e test folder

Follow up with

Which Jira/Github issue(s) this PR fixes?

Fixes #

sdcicd-1414

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot requested review from a7vicky and devppratik February 26, 2025 00:15
Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

@ritmun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.54%. Comparing base (82462bc) to head (e86d347).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   46.54%   46.54%           
=======================================
  Files           9        9           
  Lines         752      752           
=======================================
  Hits          350      350           
  Misses        392      392           
  Partials       10       10           

@ravitri ravitri mentioned this pull request Feb 26, 2025
1 task
@ravitri
Copy link
Member

ravitri commented Feb 26, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravitri, ritmun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2be6fe9 into openshift:master Feb 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants