Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the new ci-monitoring stack #34823

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Document the new ci-monitoring stack #34823

merged 3 commits into from
Dec 15, 2022

Conversation

hongkailiu
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 14, 2022
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: no rehearsable tests are affected by this change

@openshift-ci openshift-ci bot requested review from jmguzik and smg247 December 14, 2022 22:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
bbguimaraes
bbguimaraes reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@bbguimaraes bbguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos.

clusters/app.ci/ci-grafana/README.md Outdated Show resolved Hide resolved
clusters/app.ci/openshift-user-workload-monitoring/README.md Outdated Show resolved Hide resolved
@hongkailiu
Copy link
Member Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 15, 2022
@bbguimaraes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b21c662 into openshift:master Dec 15, 2022
@hongkailiu hongkailiu deleted the ci-monitoring-doc branch June 12, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbguimaraes bbguimaraes bbguimaraes left review comments

@jmguzik jmguzik Awaiting requested review from jmguzik

@smg247 smg247 Awaiting requested review from smg247

Assignees

@bbguimaraes bbguimaraes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongkailiu @openshift-ci-robot @bbguimaraes @openshift-merge-robot