Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-13341: inject assisted-service into assisted-test-infra-internal #35439

Merged
merged 1 commit into from
Jan 20, 2023
Merged

MGMT-13341: inject assisted-service into assisted-test-infra-internal #35439

merged 1 commit into from
Jan 20, 2023

Conversation

adriengentil
Copy link
Contributor

Currently, we build assisted-test-infra-internal with the latest
version of assisted-service image.

This change inject the assisted-service image of the current branch to
build assisted-test-infra-internal.

@adriengentil
MGMT-13341: inject assisted-service into assisted-test-infra-internal
5d0a6cb 
Currently, we build assisted-test-infra-internal with the latest
version of assisted-service image.

This change inject the assisted-service image of the current branch to
build assisted-test-infra-internal.
@adriengentil
Copy link
Contributor Author

/cc @osherdp @eliorerz

@openshift-ci openshift-ci bot requested review from eliorerz and osherdp January 17, 2023 11:14
@openshift-ci-robot
Copy link
Contributor

@adriengentil: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-10 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-11 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-12 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-13 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-8 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-9 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-cnv openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-day2 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-day2-arm-workers openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-day2-single-node openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ha-kube-api openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ha-kube-api-ipv4 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ha-kube-api-ipv6 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv4v6 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv6 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipxe openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-single-node openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-unbinding-single-node openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-net-suite openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-reclaim openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-reclaim-single-node openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-lvm openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-none openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ocs openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-odf openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-onprem openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-prod openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-single-node openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-static-ip-suite openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-tang openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-tpmv2 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-upgrade-agent openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-single-node-live-iso openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-single-node-with-worker-live-iso openshift/assisted-test-infra presubmit Ci-operator config changed

A total of 103 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from omertuc and tsorya January 17, 2023 11:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriengentil
Copy link
Contributor Author

adriengentil commented Jan 17, 2023 •
edited
Loading

I will rehearse once openshift/assisted-test-infra#1999 gets in

@adriengentil
Copy link
Contributor Author

/pj-rehearse auto-ack

@adriengentil
Copy link
Contributor Author

adriengentil commented Jan 20, 2023 •
edited
Loading

/pj-rehearse ack
jobs failed for unrelated reasons

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

@adriengentil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/assisted-test-infra/release-ocm-2.6/e2e-metal-assisted-kube-api-late-binding-single-node 5d0a6cb link unknown /pj-rehearse pull-ci-openshift-assisted-test-infra-release-ocm-2.6-e2e-metal-assisted-kube-api-late-binding-single-node
ci/rehearse/openshift/assisted-test-infra/release-ocm-2.7/e2e-metal-assisted-ha-kube-api 5d0a6cb link unknown /pj-rehearse pull-ci-openshift-assisted-test-infra-release-ocm-2.7-e2e-metal-assisted-ha-kube-api
ci/rehearse/openshift/assisted-test-infra/release-ocm-2.6/e2e-metal-assisted-ha-kube-api-ipv6 5d0a6cb link unknown /pj-rehearse pull-ci-openshift-assisted-test-infra-release-ocm-2.6-e2e-metal-assisted-ha-kube-api-ipv6
ci/rehearse/openshift/assisted-test-infra/release-ocm-2.6/e2e-metal-assisted-kube-api-late-unbinding-single-node 5d0a6cb link unknown /pj-rehearse pull-ci-openshift-assisted-test-infra-release-ocm-2.6-e2e-metal-assisted-kube-api-late-unbinding-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5f851c3 into openshift:master Jan 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

@adriengentil: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-assisted-test-infra-master.yaml using file ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-master.yaml
  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-assisted-test-infra-release-ocm-2.5.yaml using file ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.5.yaml
    • key openshift-assisted-test-infra-release-ocm-2.6.yaml using file ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.6.yaml
    • key openshift-assisted-test-infra-release-ocm-2.7.yaml using file ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.7.yaml

In response to this:

Currently, we build assisted-test-infra-internal with the latest
version of assisted-service image.

This change inject the assisted-service image of the current branch to
build assisted-test-infra-internal.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gpuckett-redhat pushed a commit to gpuckett-redhat/release that referenced this pull request Jan 26, 2023
@adriengentil @gpuckett-redhat
MGMT-13341: inject assisted-service into assisted-test-infra-internal (…
69a8962 
…openshift#35439)

Currently, we build assisted-test-infra-internal with the latest
version of assisted-service image.

This change inject the assisted-service image of the current branch to
build assisted-test-infra-internal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osherdp osherdp osherdp approved these changes

@eliorerz eliorerz Awaiting requested review from eliorerz

@omertuc omertuc Awaiting requested review from omertuc

@tsorya tsorya Awaiting requested review from tsorya

Assignees

@osherdp osherdp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriengentil @openshift-ci-robot @osherdp @openshift-merge-robot