Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stackrox UI e2e tests to run on FF changes #61173

Merged

Conversation

dvail
Copy link
Contributor

@dvail dvail commented Jan 31, 2025

UI e2e tests should run when feature flags are enabled/disabled due to large amounts of UI code depending on these flags.

I found that the config includes the correct file, but a trailing slash in the run_if_changed regex interprets the file path as ^pkg/features/list.go/, which causes the tests not to run. #52904 🤦

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail force-pushed the dv/fix-ui-tests-run-on-ff-change branch from be8ba84 to 331a0f4 Compare January 31, 2025 15:42
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dvail: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stackrox-stackrox-master-gke-ui-e2e-tests stackrox/stackrox presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dvail
Copy link
Contributor Author

dvail commented Jan 31, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@dvail: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dvail: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stackrox-stackrox-master-ocp-4-12-ui-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-17-ui-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-gke-ui-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dvail dvail marked this pull request as ready for review January 31, 2025 17:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@dvail
Copy link
Contributor Author

dvail commented Jan 31, 2025

The automation suggests that I
/assign @BradLugo
/cc @BradLugo

@tommartensen
Copy link
Contributor

/pj-rehearse pull-ci-stackrox-stackrox-master-ocp-4-12-ui-e2e-tests

@openshift-ci-robot
Copy link
Contributor

@tommartensen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@BradLugo
Copy link
Contributor

Sorry @dvail, I just noticed this PR. Nice catch on that regex!
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@BradLugo
Copy link
Contributor

I'm not seeing the rehearsals-ack label applied for some reason, but all the tests passed? Gonna kick off one more round of testing to be safe.
/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@BradLugo BradLugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BradLugo, dvail

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tommartensen
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@tommartensen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 12, 2025
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

@dvail: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e490d24 into openshift:master Feb 12, 2025
19 checks passed
anpingli pushed a commit to anpingli/release that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants