-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stackrox UI e2e tests to run on FF changes #61173
Fix stackrox UI e2e tests to run on FF changes #61173
Conversation
Skipping CI for Draft Pull Request. |
be8ba84
to
331a0f4
Compare
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse auto-ack |
@dvail: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-stackrox-stackrox-master-ocp-4-12-ui-e2e-tests |
@tommartensen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Sorry @dvail, I just noticed this PR. Nice catch on that regex! |
I'm not seeing the |
@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BradLugo, dvail The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse ack |
@tommartensen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@dvail: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
UI e2e tests should run when feature flags are enabled/disabled due to large amounts of UI code depending on these flags.
I found that the config includes the correct file, but a trailing slash in the
run_if_changed
regex interprets the file path as^pkg/features/list.go/
, which causes the tests not to run. #52904 🤦