Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-27595: Upgrade stackrox CI images to support Go 1.23 #61221

Merged
merged 1 commit into from
Feb 4, 2025
Merged

ROX-27595: Upgrade stackrox CI images to support Go 1.23 #61221

merged 1 commit into from
Feb 4, 2025

Conversation

BradLugo
Copy link
Contributor

@BradLugo BradLugo commented Feb 3, 2025

Description

Upgrades the stackrox images to 0.4.5 to prepare for the 1.23 Go upgrade.

/cc @davdhacs @tommartensen @RTann @msugakov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 3, 2025 •
edited by openshift-ci bot
Loading

@BradLugo: This pull request references ROX-27595 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Description

Upgrades the stackrox images to 0.4.5 to prepare for the 1.23 Go upgrade.

/cc @davdhacs @tommartensen @RTann @msugakov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@BradLugo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stackrox-stackrox-release-x.y-aro-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-eks-ebpf-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-eks-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-nongroovy-compatibility-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-nongroovy-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-operator-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-race-condition-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-scale-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-scanner-v4-install-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-sensor-integration-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-ui-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-upgrade-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-gke-version-compatibility-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-compliance-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-ebpf-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-nongroovy-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-operator-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-scanner-v4-install-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-sensor-integration-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-ui-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-17-compliance-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-17-ebpf-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-x.y-ocp-4-17-fips-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed

A total of 124 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@BradLugo
Copy link
Contributor Author

BradLugo commented Feb 3, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

RTann
RTann approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@BradLugo BradLugo mentioned this pull request Feb 3, 2025
Merged
4 tasks
davdhacs
davdhacs approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@davdhacs davdhacs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
updating master and release-x.y. not updating prior releases (not upgraded to golang 1.23) release-{3.74, 4.4, 4.5, 4.6}

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BradLugo, davdhacs, RTann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@BradLugo, pj-rehearse: failed to create rehearsal jobs ERROR:

failed waiting for prowjobs to finish: context deadline exceeded

If the problem persists, please contact Test Platform.

@BradLugo
Copy link
Contributor Author

BradLugo commented Feb 4, 2025

/pj-rehearse pull-ci-stackrox-stackrox-master-ocp-next-candidate-nongroovy-e2e-tests

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@BradLugo
Copy link
Contributor Author

BradLugo commented Feb 4, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

@BradLugo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d234b57 into openshift:master Feb 4, 2025
19 checks passed
fjglira pushed a commit to fjglira/release that referenced this pull request Feb 5, 2025
@BradLugo @fjglira
ROX-27595: Upgrade stackrox CI images to support Go 1.23 (openshift#6…
21f6026 
…1221)
jtaleric pushed a commit to jtaleric/release that referenced this pull request Feb 10, 2025
@BradLugo @jtaleric
ROX-27595: Upgrade stackrox CI images to support Go 1.23 (openshift#6…
e39207a 
…1221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTann RTann RTann approved these changes

@davdhacs davdhacs davdhacs approved these changes

@msugakov msugakov Awaiting requested review from msugakov

@tommartensen tommartensen Awaiting requested review from tommartensen

Assignees

@RTann RTann

@davdhacs davdhacs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BradLugo @openshift-ci-robot @RTann @davdhacs