Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stackrox scanner 2.36 #61481

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

RTann
Copy link
Contributor

@RTann RTann commented Feb 10, 2025

/hold

The same as 2.35 but with an updated base image (scanner-test-0.4.5) for Go 1.23

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@RTann
Copy link
Contributor Author

RTann commented Feb 10, 2025

/cc @BradLugo

@openshift-ci openshift-ci bot requested a review from BradLugo February 10, 2025 23:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@openshift-ci openshift-ci bot requested a review from jvdm February 10, 2025 23:45
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@RTann: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stackrox-scanner-release-2.36-e2e-tests stackrox/scanner presubmit Presubmit changed
pull-ci-stackrox-scanner-release-2.36-slim-e2e-tests stackrox/scanner presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RTann
Copy link
Contributor Author

RTann commented Feb 10, 2025

/cc @daynewlee @dcaravel

@openshift-ci openshift-ci bot requested review from daynewlee and dcaravel February 10, 2025 23:48
Copy link
Contributor

@BradLugo BradLugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BradLugo, RTann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BradLugo
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RTann
Copy link
Contributor Author

RTann commented Feb 11, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2025
@RTann
Copy link
Contributor Author

RTann commented Feb 11, 2025

since the branch does not exist yet, and this is just a simple copy/paste with minor changes, I'm going to just

/pj-rehearse skip

@openshift-ci-robot
Copy link
Contributor

@RTann: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@RTann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stackrox/scanner/release-2.36/slim-e2e-tests c7c5bfc link unknown /pj-rehearse pull-ci-stackrox-scanner-release-2.36-slim-e2e-tests
ci/rehearse/stackrox/scanner/release-2.36/e2e-tests c7c5bfc link unknown /pj-rehearse pull-ci-stackrox-scanner-release-2.36-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f4e665c into openshift:master Feb 11, 2025
15 of 17 checks passed
@RTann
Copy link
Contributor Author

RTann commented Feb 11, 2025

$ diff -du ci-operator/config/stackrox/scanner/stackrox-scanner-release-2.35.yaml ci-operator/config/stackrox/scanner/stackrox-scanner-release-2.36.yaml
--- ci-operator/config/stackrox/scanner/stackrox-scanner-release-2.35.yaml	2025-02-10 15:42:38
+++ ci-operator/config/stackrox/scanner/stackrox-scanner-release-2.36.yaml	2025-02-10 15:42:38
@@ -7,7 +7,7 @@
   image_stream_tag:
     name: apollo-ci
     namespace: stackrox
-    tag: scanner-test-0.4.4
+    tag: scanner-test-0.4.5
 resources:
   '*':
     requests:
@@ -80,6 +80,6 @@
           memory: 4000Mi
   timeout: 3h0m0s
 zz_generated_metadata:
-  branch: release-2.35
+  branch: release-2.36
   org: stackrox
   repo: scanner
$ diff -du ci-operator/jobs/stackrox/scanner/stackrox-scanner-release-2.35-presubmits.yaml ci-operator/jobs/stackrox/scanner/stackrox-scanner-release-2.36-presubmits.yaml
--- ci-operator/jobs/stackrox/scanner/stackrox-scanner-release-2.35-presubmits.yaml	2025-02-10 15:41:30
+++ ci-operator/jobs/stackrox/scanner/stackrox-scanner-release-2.36-presubmits.yaml	2025-02-10 15:41:30
@@ -3,9 +3,9 @@
   - agent: kubernetes
     always_run: true
     branches:
-    - ^release-2\.35$
-    - ^release-2\.35-
-    cluster: build09
+    - ^release-2\.36$
+    - ^release-2\.36-
+    cluster: build03
     context: ci/prow/e2e-tests
     decorate: true
     decoration_config:
@@ -14,7 +14,7 @@
     labels:
       ci.openshift.io/generator: prowgen
       pj-rehearse.openshift.io/can-be-rehearsed: "true"
-    name: pull-ci-stackrox-scanner-release-2.35-e2e-tests
+    name: pull-ci-stackrox-scanner-release-2.36-e2e-tests
     optional: true
     rerun_command: /test e2e-tests
     spec:
@@ -60,9 +60,9 @@
   - agent: kubernetes
     always_run: true
     branches:
-    - ^release-2\.35$
-    - ^release-2\.35-
-    cluster: build09
+    - ^release-2\.36$
+    - ^release-2\.36-
+    cluster: build03
     context: ci/prow/slim-e2e-tests
     decorate: true
     decoration_config:
@@ -71,7 +71,7 @@
     labels:
       ci.openshift.io/generator: prowgen
       pj-rehearse.openshift.io/can-be-rehearsed: "true"
-    name: pull-ci-stackrox-scanner-release-2.35-slim-e2e-tests
+    name: pull-ci-stackrox-scanner-release-2.36-slim-e2e-tests
     optional: true
     rerun_command: /test slim-e2e-tests
     spec:
$ diff -du ci-operator/jobs/stackrox/scanner/stackrox-scanner-release-2.35-postsubmits.yaml ci-operator/jobs/stackrox/scanner/stackrox-scanner-release-2.36-postsubmits.yaml
--- ci-operator/jobs/stackrox/scanner/stackrox-scanner-release-2.35-postsubmits.yaml	2025-02-10 15:41:30
+++ ci-operator/jobs/stackrox/scanner/stackrox-scanner-release-2.36-postsubmits.yaml	2025-02-10 15:41:30
@@ -3,8 +3,8 @@
   - agent: kubernetes
     always_run: true
     branches:
-    - ^release-2\.35$
-    cluster: build09
+    - ^release-2\.36$
+    cluster: build03
     decorate: true
     decoration_config:
       skip_cloning: true
@@ -12,7 +12,7 @@
     labels:
       ci.openshift.io/generator: prowgen
     max_concurrency: 1
-    name: branch-ci-stackrox-scanner-release-2.35-merge-e2e-tests
+    name: branch-ci-stackrox-scanner-release-2.36-merge-e2e-tests
     spec:
       containers:
       - args:
@@ -55,8 +55,8 @@
   - agent: kubernetes
     always_run: true
     branches:
-    - ^release-2\.35$
-    cluster: build09
+    - ^release-2\.36$
+    cluster: build03
     decorate: true
     decoration_config:
       skip_cloning: true
@@ -64,7 +64,7 @@
     labels:
       ci.openshift.io/generator: prowgen
     max_concurrency: 1
-    name: branch-ci-stackrox-scanner-release-2.35-merge-slim-e2e-tests
+    name: branch-ci-stackrox-scanner-release-2.36-merge-slim-e2e-tests
     spec:
       containers:
       - args:

@RTann RTann deleted the scanner-2.36 branch February 11, 2025 00:18
anpingli pushed a commit to anpingli/release that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants