WINC-1374,WINC-926,WINC-1373: Adjust kubelet configuration for NodeAllocatable, EvictionHard and System Memory #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test vsphere-e2e-operator |
1 similar comment
|
/test vsphere-e2e-operator |
|
/hold Needs a JIRA ticket |
openshift-ci
bot
added
the
do-not-merge/hold
|
vsphere-e2e-operator failed at deprovision, wmco e2e test passed. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Moved to draft to avoid trigger the e2e jobs |
This commit replaces the hard-coded resource names for the SystemReserved in the Kubelet configuration for the corresponding constants, so that it can react to changes and consistency.
This commit set the reserved memory for the Windows host with at least 2GiB following upstream recommendations for kubelet running on Windows.
This commit introduces EnforceNodeAllocatable with value `none` in the kubelet configuration to avoid post-processing the generated configuration. Fixes https://issues.redhat.com/browse/WINC-926
This commit explicitly set available hard-evictions thresholds for Windows. Given, the values passed are subtracted from Capacity to calculate the node allocatable to avoid defaulting to Linux-only signals.
jrvaldes
force-pushed
the
kubelet-config-updates
branch
from
1eca4a5 to
4a9b9cc
Compare
jrvaldes
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jrvaldes: This pull request references WINC-1374 which is a valid jira issue. This pull request references WINC-926 which is a valid jira issue. This pull request references WINC-1373 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold cancel |
|
Jira cards created and linked to the PR |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test vsphere-e2e-operator |
|
/test unit |
|
/test lint |
|
@jrvaldes: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test gcp-e2e-operator |
|
/test vsphere-e2e-operator |
mansikulkarni96
approved these changes
Feb 24, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, mansikulkarni96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
nonein the kubelet configuration to avoid post-processing the generated configuration (WINC-926)In addition, aligns the e2e test with the proposed configuration.
Resulting kubelet configuration with the proposed changes.
{ "kubeletconfig": { "enableServer": true, "podLogsDir": "/var/log/pods", "syncFrequency": "1m0s", "fileCheckFrequency": "20s", "httpCheckFrequency": "20s", "address": "0.0.0.0", "port": 10250, "rotateCertificates": true, "serverTLSBootstrap": true, "authentication": { "x509": { "clientCAFile": "C:\\k\\kubelet-ca.crt" }, "webhook": { "enabled": true, "cacheTTL": "2m0s" }, "anonymous": { "enabled": false } }, "authorization": { "mode": "Webhook", "webhook": { "cacheAuthorizedTTL": "5m0s", "cacheUnauthorizedTTL": "30s" } }, "registryPullQPS": 5, "registryBurst": 10, "eventRecordQPS": 50, "eventBurst": 100, "enableDebuggingHandlers": true, "healthzPort": 10248, "healthzBindAddress": "127.0.0.1", "oomScoreAdj": -999, "clusterDomain": "cluster.local", "clusterDNS": [ "172.30.0.10" ], "streamingConnectionIdleTimeout": "4h0m0s", "nodeStatusUpdateFrequency": "10s", "nodeStatusReportFrequency": "5m0s", "nodeLeaseDurationSeconds": 40, "imageMinimumGCAge": "2m0s", "imageMaximumGCAge": "0s", "imageGCHighThresholdPercent": 85, "imageGCLowThresholdPercent": 80, "volumeStatsAggPeriod": "1m0s", "cgroupsPerQOS": false, "cgroupDriver": "cgroupfs", "cpuManagerPolicy": "none", "cpuManagerReconcilePeriod": "10s", "memoryManagerPolicy": "None", "topologyManagerPolicy": "none", "topologyManagerScope": "container", "runtimeRequestTimeout": "10m0s", "hairpinMode": "promiscuous-bridge", "maxPods": 250, "podPidsLimit": -1, "resolvConf": "", "cpuCFSQuota": true, "cpuCFSQuotaPeriod": "100ms", "nodeStatusMaxImages": 50, "maxOpenFiles": 1000000, "contentType": "application/vnd.kubernetes.protobuf", "kubeAPIQPS": 50, "kubeAPIBurst": 100, "serializeImagePulls": false, "evictionHard": { "imagefs.available": "15%", "nodefs.available": "10%" }, "evictionPressureTransitionPeriod": "5m0s", "enableControllerAttachDetach": true, "makeIPTablesUtilChains": true, "iptablesMasqueradeBit": 14, "iptablesDropBit": 15, "featureGates": { "RotateKubeletServerCertificate": true }, "failSwapOn": true, "memorySwap": {}, "containerLogMaxSize": "50Mi", "containerLogMaxFiles": 5, "containerLogMaxWorkers": 1, "containerLogMonitorInterval": "10s", "configMapAndSecretChangeDetectionStrategy": "Watch", "systemReserved": { "cpu": "500m", "ephemeral-storage": "1Gi", "memory": "2Gi" }, "enforceNodeAllocatable": [ "none" ], "volumePluginDir": "/usr/libexec/kubernetes/kubelet-plugins/volume/exec/", "logging": { "format": "text", "flushFrequency": "5s", "verbosity": 2, "options": { "text": { "infoBufferSize": "0" }, "json": { "infoBufferSize": "0" } } }, "enableSystemLogHandler": true, "enableSystemLogQuery": true, "shutdownGracePeriod": "0s", "shutdownGracePeriodCriticalPods": "0s", "crashLoopBackOff": {}, "enableProfilingHandler": true, "enableDebugFlagsHandler": true, "seccompDefault": false, "memoryThrottlingFactor": 0.9, "registerWithTaints": [ { "key": "os", "value": "Windows", "effect": "NoSchedule" } ], "registerNode": true, "localStorageCapacityIsolation": true, "containerRuntimeEndpoint": "npipe://./pipe/containerd-containerd", "failCgroupV1": false } }