-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core.yaml #1121
Merged
Merged
Update core.yaml #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Commit:** fabric8-services/fabric8-wit@11904c7 **Author:** Konrad Kleine ([email protected]) **Date:** 2018-10-10T13:49:39+02:00 Assign number to new areas/iterations and allow searching by it (fabric8-services/fabric8-wit#2311) Existing iterations and areas are not touched and won't have a number assigned to them. This will come in a later change. This is a code-only change to proof that it is backwards compatible. See https://openshift.io/openshiftio/Openshift_io/plan/detail/618 Most of the code in this change comes from this PR which was later revered: fabric8-services/fabric8-wit#2311 ---- **Commit:** fabric8-services/fabric8-wit@8674b7b **Author:** Konrad Kleine ([email protected]) **Date:** 2018-10-10T16:58:17+02:00 update number for existing iterations (fabric8-services/fabric8-wit#2314) This updates all existing iterations and assigns a number to each iteration partitioned by space and in ascending order by creation time. This change also makes the number a not-NULLable column on the iterations. Also a constraint (`iterations_space_id_number_idx`) is created that ensures an iteration number can only occur once per iteration. ---- **Commit:** fabric8-services/fabric8-wit@e67b5e2 **Author:** nurali-techie ([email protected]) **Date:** 2018-10-15T14:00:33+05:30 stop calling analytics api for cve scan reg/de-reg (fabric8-services/fabric8-wit#2316) ---- **Commit:** fabric8-services/fabric8-wit@37a913a **Author:** Baiju Muthukadan ([email protected]) **Date:** 2018-10-15T17:07:20+05:30 Include fabric8-common as a dependency (fabric8-services/fabric8-wit#2318) - Replace id package ---- **Commit:** fabric8-services/fabric8-wit@e09b805 **Author:** Konrad Kleine ([email protected]) **Date:** 2018-10-15T14:44:35+02:00 Use Postgres CTE to update iteration numbers (fabric8-services/fabric8-wit#2319) Use Postgres CTE to update iteration numbers When explaining the updae before it looks like this: ``` postgres@172:postgres> explain UPDATE iterations iter SET number = seq.row_number FROM ( SELECT id, space_id, created_at, row_number() OVER (PARTITION BY space_id ORDER BY created_at ASC) FROM iterations ) AS seq WHERE iter.space_id = seq.space_id AND iter.id = seq.id; +-----------------------------------------------------------------------------------------+ | QUERY PLAN | |-----------------------------------------------------------------------------------------| | Update on iterations iter (cost=2.06..2.16 rows=1 width=263) | | -> Merge Join (cost=2.06..2.16 rows=1 width=263) | | Merge Cond: (seq.space_id = iter.space_id) | | Join Filter: (iter.id = seq.id) | | -> Subquery Scan on seq (cost=1.03..1.09 rows=2 width=112) | | -> WindowAgg (cost=1.03..1.07 rows=2 width=48) | | -> Sort (cost=1.03..1.03 rows=2 width=40) | | Sort Key: iterations.space_id, iterations.created_at | | -> Seq Scan on iterations (cost=0.00..1.02 rows=2 width=40) | | -> Sort (cost=1.03..1.03 rows=2 width=187) | | Sort Key: iter.space_id | | -> Seq Scan on iterations iter (cost=0.00..1.02 rows=2 width=187) | +-----------------------------------------------------------------------------------------+ ``` Now the update looks better (notice absence of nested seq scans): ``` postgres@172:postgres> explain WITH iteration_numbers AS ( SELECT *, ROW_NUMBER() OVER(PARTITION BY space_id ORDER BY created_at ASC) AS num FROM iterations ) UPDATE iterations SET number = (SELECT num FROM iteration_numbers WHERE iteration_numbers.id = iterations.id); +---------------------------------------------------------------------------------------------+ | QUERY PLAN | |---------------------------------------------------------------------------------------------| | Update on iterations (cost=1.07..2.18 rows=2 width=191) | | CTE iteration_numbers | | -> WindowAgg (cost=1.03..1.07 rows=2 width=193) | | -> Sort (cost=1.03..1.03 rows=2 width=185) | | Sort Key: iterations_1.space_id, iterations_1.created_at | | -> Seq Scan on iterations iterations_1 (cost=0.00..1.02 rows=2 width=185) | | -> Seq Scan on iterations (cost=0.00..1.11 rows=2 width=191) | | SubPlan 2 | | -> CTE Scan on iteration_numbers (cost=0.00..0.04 rows=1 width=8) | | Filter: (id = iterations.id) | +---------------------------------------------------------------------------------------------+ ``` ---- **Commit:** fabric8-services/fabric8-wit@1724c15 **Author:** Ibrahim Jarif ([email protected]) **Date:** 2018-10-23T10:12:56+05:30 Rearrage search repository blackbox tests (fabric8-services/fabric8-wit#2322) ---- **Commit:** fabric8-services/fabric8-wit@7fda6af **Author:** Ibrahim Jarif ([email protected]) **Date:** 2018-10-23T13:49:11+05:30 Make agile default template for space creation (fabric8-services/fabric8-wit#2323) The default template used for space creation will be `Agile`. Rest of the changes are fixes to the tests which depended on the default template. I've changed them to use `fxt.WorkitemTypes` instead of `workitem.SystemFeature/workitem.SystemBug` See fabric8-services/fabric8-wit#2317 and openshiftio/openshift.io#4427 ---- **Commit:** fabric8-services/fabric8-wit@7b78cf6 **Author:** Konrad Kleine ([email protected]) **Date:** 2018-10-23T11:54:01+02:00 Postpone iteration number update (fabric8-services/fabric8-wit#2325) Currently the database migration 110 won't go through on prod-preview. I'm postponing it for now. * Reverts "update number for existing iterations (fabric8-services/fabric8-wit#2314)" * This reverts commit 8674b7b56a9226b3bbd6ebf7b0179f127ff6a0a2. * Revert "Use Postgres CTE to update iteration numbers (fabric8-services/fabric8-wit#2319)" * This reverts commit e09b8055ac7cff0ad32e12a3fe361888666bbbc9. ---- **Commit:** fabric8-services/fabric8-wit@22e3d5d **Author:** Dhriti Shikhar ([email protected]) **Date:** 2018-10-23T16:06:35+05:30 Enable the delete workitem endpoint (fabric8-services/fabric8-wit#2305) Enables delete workitem endpoint ---- **Commit:** fabric8-services/fabric8-wit@3d163c7 **Author:** Ibrahim Jarif ([email protected]) **Date:** 2018-10-23T17:45:11+05:30 Increase deployment timeout to 2X (fabric8-services/fabric8-wit#2327) See fabric8-services/fabric8-wit#2291 ---- **Commit:** fabric8-services/fabric8-wit@9879836 **Author:** Ibrahim Jarif ([email protected]) **Date:** 2018-10-24T11:30:20+05:30 Do not throw 500 on invalid value type in search API (fabric8-services/fabric8-wit#2321) Fixes openshiftio/openshift.io#4429 ---- **Commit:** fabric8-services/fabric8-wit@44739f8 **Author:** Ibrahim Jarif ([email protected]) **Date:** 2018-10-25T10:57:03+05:30 Remove redundant code and fix typo (fabric8-services/fabric8-wit#2329) ----
kwk
approved these changes
Oct 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This description was generated using this script:
Invoked as:
Commit: fabric8-services/fabric8-wit@11904c7
Author: Konrad Kleine ([email protected])
Date: 2018-10-10T13:49:39+02:00
Assign number to new areas/iterations and allow searching by it (fabric8-services/fabric8-wit#2311)
Existing iterations and areas are not touched and won't have a number
assigned to them. This will come in a later change.
This is a code-only change to proof that it is backwards compatible.
See https://openshift.io/openshiftio/Openshift_io/plan/detail/618
Most of the code in this change comes from this PR which was later revered: fabric8-services/fabric8-wit#2311
Commit: fabric8-services/fabric8-wit@8674b7b
Author: Konrad Kleine ([email protected])
Date: 2018-10-10T16:58:17+02:00
update number for existing iterations (fabric8-services/fabric8-wit#2314)
This updates all existing iterations and assigns a number to each iteration partitioned by space and in ascending order by creation time.
This change also makes the number a not-NULLable column on the iterations.
Also a constraint (
iterations_space_id_number_idx
) is created that ensures an iteration number can only occur once per iteration.Commit: fabric8-services/fabric8-wit@e67b5e2
Author: nurali-techie ([email protected])
Date: 2018-10-15T14:00:33+05:30
stop calling analytics api for cve scan reg/de-reg (fabric8-services/fabric8-wit#2316)
Commit: fabric8-services/fabric8-wit@37a913a
Author: Baiju Muthukadan ([email protected])
Date: 2018-10-15T17:07:20+05:30
Include fabric8-common as a dependency (fabric8-services/fabric8-wit#2318)
Commit: fabric8-services/fabric8-wit@e09b805
Author: Konrad Kleine ([email protected])
Date: 2018-10-15T14:44:35+02:00
Use Postgres CTE to update iteration numbers (fabric8-services/fabric8-wit#2319)
Use Postgres CTE to update iteration numbers
When explaining the updae before it looks like this:
Now the update looks better (notice absence of nested seq scans):
Commit: fabric8-services/fabric8-wit@1724c15
Author: Ibrahim Jarif ([email protected])
Date: 2018-10-23T10:12:56+05:30
Rearrage search repository blackbox tests (fabric8-services/fabric8-wit#2322)
Commit: fabric8-services/fabric8-wit@7fda6af
Author: Ibrahim Jarif ([email protected])
Date: 2018-10-23T13:49:11+05:30
Make agile default template for space creation (fabric8-services/fabric8-wit#2323)
The default template used for space creation will be
Agile
.Rest of the changes are fixes to the tests which depended on the default template. I've changed them to use
fxt.WorkitemTypes
instead ofworkitem.SystemFeature/workitem.SystemBug
See fabric8-services/fabric8-wit#2317 and openshiftio/openshift.io#4427
Commit: fabric8-services/fabric8-wit@7b78cf6
Author: Konrad Kleine ([email protected])
Date: 2018-10-23T11:54:01+02:00
Postpone iteration number update (fabric8-services/fabric8-wit#2325)
Currently the database migration 110 won't go through on prod-preview. I'm postponing it for now.
Commit: fabric8-services/fabric8-wit@22e3d5d
Author: Dhriti Shikhar ([email protected])
Date: 2018-10-23T16:06:35+05:30
Enable the delete workitem endpoint (fabric8-services/fabric8-wit#2305)
Enables delete workitem endpoint
Commit: fabric8-services/fabric8-wit@3d163c7
Author: Ibrahim Jarif ([email protected])
Date: 2018-10-23T17:45:11+05:30
Increase deployment timeout to 2X (fabric8-services/fabric8-wit#2327)
See fabric8-services/fabric8-wit#2291
Commit: fabric8-services/fabric8-wit@9879836
Author: Ibrahim Jarif ([email protected])
Date: 2018-10-24T11:30:20+05:30
Do not throw 500 on invalid value type in search API (fabric8-services/fabric8-wit#2321)
Fixes openshiftio/openshift.io#4429
Commit: fabric8-services/fabric8-wit@44739f8
Author: Ibrahim Jarif ([email protected])
Date: 2018-10-25T10:57:03+05:30
Remove redundant code and fix typo (fabric8-services/fabric8-wit#2329)