driver: tuyaMCU: introduce battery-powered device ack-delay #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the generic idea is good, I am not sure if it should be 20 by default. People will not notice it and it will drain battery fast. Maybe change default value to 0 and also add code to change this value to 20 when a pairing button is pressed, or something like that? I am not sure if I remember correctly, but we had some kind of pair message from tuya battery device received... |
This introduces a delay for sending the ACKs on battery powered TuyaMCU sensors. Rationale is to allow users to delay the return to sleep state. This is useful when e.g. changing settings on the device. Currently the device is sent back to sleep after the status has been read and commited to MQTT. This can be less than 5 seconds of uptime. Set this value to a sane default, which allows the device to retain online for enough time for a user to change configuration. Signed-off-by: David Bauer <[email protected]>
Signed-off-by: David Bauer <[email protected]>
blocktrron
force-pushed
the
pr-tuya-mcu-battery-ack-delay
branch
from
bb4b45a to
b0a0a46
Compare
|
You seem to be right. I'll look into this and ping you once i have something ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a delay for sending the ACKs on battery powered TuyaMCU sensors.
Rationale is to allow users to delay the return to sleep state. This is useful when e.g. changing settings on the device.
Currently the device is sent back to sleep after the status has been read and commited to MQTT. This can be less than 5 seconds of uptime.
Set this value to a sane default, which allows the device to retain online for enough time for a user to change configuration.