-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACKUP] Build cluster form ClusterInfo #1608
[BACKUP] Build cluster form ClusterInfo #1608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chaohengstudent 感謝修正,幾個建議請看一下
common/src/main/java/org/astraea/common/backup/ClusterRestorer.java
Outdated
Show resolved
Hide resolved
… module. add test with createTopicWithReplicasAssignment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
main class 還有點簡陋,麻煩開一個議題(如果還沒開的話)來討論後續的使用方式
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
failed test is traced by #1613 |
related to #1520
主要內容
TopicCreator
中新增replicasAssignments
作為還原叢集時配置 replica leader follower所在 broker 位置。ClusterRestorer
根據ClusterInfo
還原叢集配置目前還原配置的限制:
ClusterInfo
的broker id
必須一致