Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKUP] Build cluster form ClusterInfo #1608

Merged

Conversation

chaohengstudent
Copy link
Collaborator

related to #1520

主要內容

  1. TopicCreator 中新增 replicasAssignments 作為還原叢集時配置 replica leader follower所在 broker 位置。
  2. 新增 class ClusterRestorer 根據 ClusterInfo 還原叢集配置
  3. 新增測試

目前還原配置的限制:

  1. 提供的叢集與 ClusterInfobroker id 必須一致
  2. 提供的叢集須為乾淨空的

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaohengstudent 感謝修正,幾個建議請看一下

… module. add test with createTopicWithReplicasAssignment.
chia7712
chia7712 previously approved these changes Mar 29, 2023
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

main class 還有點簡陋,麻煩開一個議題(如果還沒開的話)來討論後續的使用方式

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaohengstudent
Copy link
Collaborator Author

failed test is traced by #1613

@chaohengstudent chaohengstudent merged commit 0472613 into opensource4you:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants