Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sdk dependencies #2767

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Upgrade sdk dependencies #2767

merged 7 commits into from
Sep 19, 2023

Conversation

ellykits
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2749

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2767 (3cf3c5f) into main (ad3a737) will increase coverage by 1.4%.
Report is 58 commits behind head on main.
The diff coverage is 63.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2767     +/-   ##
=========================================
+ Coverage     64.5%   65.9%   +1.4%     
- Complexity    1075    1078      +3     
=========================================
  Files          218     222      +4     
  Lines         9635   10015    +380     
  Branches      1897    1840     -57     
=========================================
+ Hits          6218    6605    +387     
- Misses        2234    2288     +54     
+ Partials      1183    1122     -61     
Flag Coverage Δ
engine 72.3% <71.0%> (-0.4%) ⬇️
geowidget 65.5% <33.3%> (+1.1%) ⬆️
quest 61.4% <55.9%> (+2.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ata/remote/fhir/resource/FhirResourceDataSource.kt 93.3% <0.0%> (+0.4%) ⬆️
...hircore/engine/domain/model/FhirResourceConfigs.kt 43.2% <0.0%> (-1.3%) ⬇️
...ster/fhircore/engine/p2p/dao/BaseP2PTransferDao.kt 70.9% <0.0%> (-19.5%) ⬇️
...martregister/fhircore/engine/sync/AppSyncWorker.kt 100.0% <ø> (ø)
...ter/fhircore/engine/sync/OpenSrpDownloadManager.kt 42.8% <0.0%> (ø)
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 30.4% <0.0%> (-2.9%) ⬇️
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 80.0% <0.0%> (-2.8%) ⬇️
...ter/fhircore/quest/data/QuestXFhirQueryResolver.kt 0.0% <0.0%> (-100.0%) ⬇️
...register/fhircore/quest/event/ToolbarClickEvent.kt 0.0% <0.0%> (ø)
... and 56 more

... and 31 files with indirect coverage changes

@ellykits ellykits added Discussion This is an open discussion that may or may not lead to actionable points Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions labels Sep 19, 2023
@pld pld merged commit aaacdbb into main Sep 19, 2023
@pld pld deleted the upgrade-sdk-dependencies branch September 19, 2023 13:55
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Upgrade SDC and engine library

Signed-off-by: Elly Kitoto <[email protected]>

* Update documentation on Remote Publishing

Signed-off-by: Elly Kitoto <[email protected]>

* Upgrade FHIR engine dependency

Signed-off-by: Elly Kitoto <[email protected]>

* Resolve failing tests

Signed-off-by: Elly Kitoto <[email protected]>

---------

Signed-off-by: Elly Kitoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion This is an open discussion that may or may not lead to actionable points Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade SDC and Engine libraries
2 participants