Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RapidPro implementation #616

Open
wants to merge 434 commits into
base: master
Choose a base branch
from
Open

Conversation

ellykits
Copy link
Contributor

No description provided.

Rkareko and others added 30 commits October 7, 2021 18:21
Add type handler for template
Fix opensrp location to fhir location convertion bug
* include task owner when using rabiitmq profile

* add initializePathEvaluator method
hilpitome and others added 24 commits June 30, 2022 15:27
…an-to-lombrok

use lombok in PractitionerSearchBean
…event-json-v2

Bug Fix: Handle Missing baseEntityId in Event JSON for Save for v2
V2 upgrade com.fasterxml.jackson.core artifacts to version 2.14.0
…-core into rapidpro-refactor

Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
null, false)).thenReturn(1l);
Map<String, String> properties = new HashMap<>();
properties.put(PlanConstants.TYPE, PlanConstants.LARVAL_DIPPING_SITE);
List<String> structureIds = new ArrayList<>();

Check failure

Code scanning / CodeQL

Container contents are never accessed

The contents of this container are never accessed.
null, false)).thenReturn(1l);
Map<String, String> properties = new HashMap<>();
properties.put(PlanConstants.TYPE, PlanConstants.MOSQUITO_COLLECTION_POINT);
List<String> structureIds = new ArrayList<>();

Check failure

Code scanning / CodeQL

Container contents are never accessed

The contents of this container are never accessed.
};

public Integer getPlanTemplate(Event event) {
String historicalIntervention = getHistoricalIntervention(Collections.singletonList(event.getLocationId()));

Check warning

Code scanning / CodeQL

Dereferenced variable may be null

Variable [event](1) may be null at this access as suggested by [this](2) null guard.
@@ -129,17 +129,21 @@
List<String> updatedTaskIds = new ArrayList<>();
for (TaskUpdate taskUpdate : taskUpdates) {
Task task = taskRepository.get(taskUpdate.getIdentifier());
logger.info("UpdateTaskStatus retrieved task from db with id : " + task.getIdentifier());

Check warning

Code scanning / CodeQL

Dereferenced variable may be null

Variable [task](1) may be null at this access as suggested by [this](2) null guard.
}
}

protected void addCriterion(String condition, Object value1, Object value2, String property) {

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'property' is never used.
}
}

protected void addCriterion(String condition, Object value, String property) {

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'property' is never used.

List<Event> convertContactToEvents(RapidProContact rapidProContact);

RapidProContact convertEventToContact(Event event);

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'event' is never used.
} else {
String lastItem = splitVaccine[splitVaccine.length - 1];
if (StringUtils.isNumeric(lastItem)) {
return String.valueOf(Integer.parseInt(lastItem) + 1);

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.
@ndegwamartin ndegwamartin force-pushed the rapidpro-refactor-master branch 3 times, most recently from 064d425 to 5c02267 Compare February 17, 2023 10:54
@ndegwamartin ndegwamartin force-pushed the rapidpro-refactor-master branch from 5c02267 to af18e93 Compare February 17, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants