-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RapidPro implementation #616
base: master
Are you sure you want to change the base?
Conversation
Add type handler for template
Signed-off-by: Elly Kitoto <[email protected]>
Fix opensrp location to fhir location convertion bug
* include task owner when using rabiitmq profile * add initializePathEvaluator method
…iltered by properties
Populate task reason reference value
…an-to-lombrok use lombok in PractitionerSearchBean
…event-json-v2 Bug Fix: Handle Missing baseEntityId in Event JSON for Save for v2
V2 upgrade com.fasterxml.jackson.core artifacts to version 2.14.0
Signed-off-by: Elly Kitoto <[email protected]>
…-core into rapidpro-refactor Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
null, false)).thenReturn(1l); | ||
Map<String, String> properties = new HashMap<>(); | ||
properties.put(PlanConstants.TYPE, PlanConstants.LARVAL_DIPPING_SITE); | ||
List<String> structureIds = new ArrayList<>(); |
Check failure
Code scanning / CodeQL
Container contents are never accessed
null, false)).thenReturn(1l); | ||
Map<String, String> properties = new HashMap<>(); | ||
properties.put(PlanConstants.TYPE, PlanConstants.MOSQUITO_COLLECTION_POINT); | ||
List<String> structureIds = new ArrayList<>(); |
Check failure
Code scanning / CodeQL
Container contents are never accessed
}; | ||
|
||
public Integer getPlanTemplate(Event event) { | ||
String historicalIntervention = getHistoricalIntervention(Collections.singletonList(event.getLocationId())); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
@@ -129,17 +129,21 @@ | |||
List<String> updatedTaskIds = new ArrayList<>(); | |||
for (TaskUpdate taskUpdate : taskUpdates) { | |||
Task task = taskRepository.get(taskUpdate.getIdentifier()); | |||
logger.info("UpdateTaskStatus retrieved task from db with id : " + task.getIdentifier()); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
} | ||
} | ||
|
||
protected void addCriterion(String condition, Object value1, Object value2, String property) { |
Check notice
Code scanning / CodeQL
Useless parameter
} | ||
} | ||
|
||
protected void addCriterion(String condition, Object value, String property) { |
Check notice
Code scanning / CodeQL
Useless parameter
|
||
List<Event> convertContactToEvents(RapidProContact rapidProContact); | ||
|
||
RapidProContact convertEventToContact(Event event); |
Check notice
Code scanning / CodeQL
Useless parameter
} else { | ||
String lastItem = splitVaccine[splitVaccine.length - 1]; | ||
if (StringUtils.isNumeric(lastItem)) { | ||
return String.valueOf(Integer.parseInt(lastItem) + 1); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
064d425
to
5c02267
Compare
5c02267
to
af18e93
Compare
No description provided.