Fixes endpoint discovery for RGW application under test #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zaza test used the default endpoint as exposed by the unit to perform object IO, however, SSL is configured for PUBLIC,INTERNAL, and ADMIN bindings. Signed-off-by: Utkarsh Bhatt <[email protected]>
UtkarshBhatthere
force-pushed
the
fix/CephRgwApacheSsl
branch
from
3bcd3ff
to
21b51a4
Compare
sabaini
reviewed
Jun 12, 2024
There was a problem hiding this comment.
This feels like there exists a bug in zaza_model.get_unit_public_address()
Seeing as there have been numerous issues with this method in the past I wonder if there has been a regression.
This method also has two different implementations, with a feature flag switching between them. I wonder if setting this feature flag helps?
|
sabaini
approved these changes
Jun 14, 2024
|
@UtkarshBhatthere Please could you add some description into the PR about why this patch is needed; i.e does it fix a bug? Is it a regression being resolved? A workaround? i.e. we need something to explain why this should be included right up in the description of the PR. Thank. |
ajkavanagh
requested changes
Jun 17, 2024
|
@ajkavanagh Thanks for the reminder, I have added a description for the change. |
ajkavanagh
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charm-Ceph-RGW configures Apache for Admin/Public bindings. The original test queries the charm for the default public address (i.e. address on the "" binding) to perform object IO (S3) which fails because the endpoint is not correct. For IO test, we need to fetch the address bound to the
PUBLICjuju space, this PR fetches the same withnetwork-getand uses that to perform object IO instead.