Add ObjectRetrier to CinderaBackupTests #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the auto-retrier to the cinder client to get past race hazards and other transient errors.
It wasn't capturing member variables on the wrapped object that would then be used to make the call; thus, wrap those. This also disables (temporarily) the long running cinder backup test deletion whilst checking whether retries are the problem.
This is to verify that the retries really do work.
In order to ensure that an object that contains other objects that are called (e.g. the VolumeManager object on the Cinder client object), the ObjectRetrierWraps class needs to more agressively wrap non builtin classes.
This accounts for slow ServerStack when using ceph in the model.
Due to slow 1GiB networking in ServerStack the restore often exceeds the retries. Increase them to enable the restore to succeed.
The test for log function against ObjectRetrierWraps class is too brittle to the number of log calls. This commit makes it less brittle.
wolsen
approved these changes
Jul 1, 2024
wolsen
added a commit
that referenced
this pull request
Jul 2, 2024
[main] ObjectRetrierWraps fixes (cherry-pick #1234)
freyes
added a commit
that referenced
this pull request
Jul 11, 2024
[bobcat] ObjectRetrierWraps fixes (cherry-pick #1234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the auto-retrier to the cinder client to get past race hazards
and other transient errors.