Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: test enable octavia in uni06zeta #346

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lavraham
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from abays and leifmadsen July 30, 2024 08:15
Copy link

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lavraham
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lavraham lavraham marked this pull request as draft July 30, 2024 08:19
@fultonj fultonj requested review from beagles and gthiemonge and removed request for leifmadsen July 31, 2024 12:57
@fultonj
Copy link
Contributor

fultonj commented Jul 31, 2024

This will only affect the unified job, not the component ci job.
Do we want to leave this false by default and enable it on a per job level instead?
Waiting to get feedback from @beagles @gthiemonge

@fultonj fultonj added the needs-info Information is requested of the reporter or reviewers label Jul 31, 2024
@lavraham
Copy link
Contributor Author

lavraham commented Aug 1, 2024

This will only affect the unified job, not the component ci job. Do we want to leave this false by default and enable it on a per job level instead? Waiting to get feedback from @beagles @gthiemonge
Octavia also part of uni-zeta job, I created this PR to enabled Octavia in the deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress needs-info Information is requested of the reporter or reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants