-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Heat for uni04delta-ipv6 DT #411
Enable Heat for uni04delta-ipv6 DT #411
Conversation
Hi @gmarcian. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/aprove
/lgtm
I verified that I could build delta-ipv6 with this change and diff'd the output before and after. the only diff is that heat is enabled as it should be.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fultonj, gmarcian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick 18.0.0-proposed |
@gmarcian: only openstack-k8s-operators org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
recheck-gate |
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
6c766ab
into
openstack-k8s-operators:main
/cherrypick 18.0.0-proposed |
@abays: new pull request created: #416 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Enable Heat for uni04delta-ipv6 DT It was a cherry-picked from #411 Reviewed-by: Andrew Bays <[email protected]>
Since Tobiko tf uses Heat, we need to enable it in order to run Tobiko tests.