Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Heat for uni04delta-ipv6 DT #411

Conversation

gmarcian
Copy link
Contributor

@gmarcian gmarcian commented Oct 1, 2024

Since Tobiko tf uses Heat, we need to enable it in order to run Tobiko tests.

Copy link

openshift-ci bot commented Oct 1, 2024

Hi @gmarcian. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/aprove
/lgtm

I verified that I could build delta-ipv6 with this change and diff'd the output before and after. the only diff is that heat is enabled as it should be.

Copy link

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, gmarcian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 2, 2024
@fultonj
Copy link
Contributor

fultonj commented Oct 2, 2024

@fultonj fultonj added the needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges label Oct 2, 2024
@gmarcian
Copy link
Contributor Author

gmarcian commented Oct 9, 2024

/cherrypick 18.0.0-proposed

@openshift-cherrypick-robot

@gmarcian: only openstack-k8s-operators org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gmarcian
Copy link
Contributor Author

gmarcian commented Oct 9, 2024

@fultonj please see: #415
BTW, may i ask to add me as a member to the openstack-k8s-operators org?

@abays
Copy link
Contributor

abays commented Oct 9, 2024

@fultonj please see: #415 BTW, may i ask to add me as a member to the openstack-k8s-operators org?

@gmarcian Invite sent

@abays
Copy link
Contributor

abays commented Oct 9, 2024

recheck-gate

Copy link
Contributor

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6c766ab into openstack-k8s-operators:main Oct 9, 2024
7 checks passed
@abays
Copy link
Contributor

abays commented Oct 9, 2024

/cherrypick 18.0.0-proposed

@openshift-cherrypick-robot

@abays: new pull request created: #416

In response to this:

/cherrypick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

softwarefactory-project-zuul bot added a commit that referenced this pull request Oct 18, 2024
Enable Heat for uni04delta-ipv6 DT

It was a cherry-picked from #411

Reviewed-by: Andrew Bays <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges needs-ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants