-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compute-starter-kit dt #60
base: main
Are you sure you want to change the base?
Add compute-starter-kit dt #60
Conversation
a778b56
to
b1ca096
Compare
dd000d2
to
9cf89d7
Compare
@fultonj i have not actually tested this beyond rendering the crs with kustomize locally but this is a port of the old nova compute kit ci toplogy i wrote last year overlayed on the lib functions you intoduced https://github.com/openstack-k8s-operators/nova-operator/tree/main/ci/nova-operator-compute-kit one slight annoyance is ideaaly we would start with a contol plane with all service disabled and then enabled only the ones needed i have a couple of opens with the current version mainly around how do i correctly expose the rest apis as routes? and then obviously i need to extend this to have 2 edpm nodes in cell 1 before it actully complete |
9cf89d7
to
fd9ce98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising. This is just a first pass. I'll do a follow up review.
This is a collection of CR templates that represent a openstack deployment | ||
topology that has the following characteristics: | ||
|
||
- Single noe OpenShift cluster (CRC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node
|
||
All stages must be executed in the order listed below. Everything is required unless otherwise indicated. | ||
|
||
1. [Install the OpenStack K8S operators and their dependencies]../(../../common/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the markdown link syntax so it renders correcty.
``` | ||
oc project openstack | ||
``` | ||
Change to the hci directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be Change to the compute-starter-kit/edpm directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
this file is mostly just a copy past right now but ill correct this when i get to the datapalne part
this dt will have at least the following phases.
deploy openstack with nova and cell0
deploy cell1
- first deploy the contolplane part of cell1 and then waith for ti to be readay
- then deploy the dataplane
finally perfrom post install config (flavor/image creations) and run tests.
metallb.universe.tf/loadBalancerIPs: 172.17.0.86 | ||
|
||
lbServiceType: LoadBalancer | ||
storageClass: crc-csi-hostpath-provisioner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we define additional nova compute configuration and then use customize to copy that into the DataPlaneService/nova? E.g. enabling cpu pinning for the second scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proably yes i have not got to the edpm part yet.
fd9ce98
to
5a2ecd9
Compare
this is just a rebase to take account of the changes in the repo and i fixed 2 issues with this nova/placment deploy properly glance is failing with some pod creation issue related to the storage network we will have to figure that out. my guess is the network config in this dt is not compatible with CRC currently and needs to be adjusted but i have not really had time to figure out how that is working |
prefix-length: 24 | ||
iface: enp7s0.21 | ||
vlan: 21 | ||
base_iface: enp7s0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my best guess right now is this was broken because i had not done
make crc_attach_default_interface before i applied this so this probably failed and that is why the glance dbsync pod was failing to spawn
base_iface: enp7s0 probably did not exist
so this network probably didn't get create properly
error configuring pod [openstack/glance-db-sync-9wz75] networking: [openstack/glance-db-sync-9wz75/165e4d20-d6d9-4edc-873e-8a5fa269fe9d:storage]: error adding container to network "storage": Link not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep for crc this is
enp6s0
data: | ||
# nodes | ||
node_0: | ||
name: crc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this needs to be updated to match the name of the CRC VM
for my current instance this should be
node_0:
name: crc-n5gv4-master-0
internalapi_ip: 172.17.0.5
tenant_ip: 172.19.0.5
ctlplane_ip: 192.168.122.19
storage_ip: 172.18.0.5
that is why the network config was broken
it was not finding a node called crc
version: v1beta1 | ||
- path: control-plane/disable.yaml | ||
- path: control-plane/infra.yaml | ||
- path: control-plane/nova.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glance and neutron seam to be defaulting to 0 replicas so i just need to add a patch file for each and they should deploy
5a2ecd9
to
769000d
Compare
just a very quick update this now depoys on crc correctly when using this locally you will have to update eh node_0 name to match your crc instances hostname steps to use this are crc start nova will be deployed with cell 0 only in a future version ill add the steps for adding nova-cell1 and adding edpm nodes to this for now I'm going to put this on hold for a week or two while i work on nova stuff. |
Discussed this during triage, and we're wondering if this was a good idea for implementation, but maybe we can close this for now, and revisit in the future if the priority bubbles back up? |
to me this is required before we can move the ci framework jobs to all be based on the architecture repo. so this is not a priority for beta or even ga but i actually think |
Perhaps this should be moved to a Jira for tracking, scoping, and backlog prioritization rather than leaving this hanging open. If this is not a target for beta or GA, and is more tied to CIFMW integration, then I think it might be best to offline this and start with planning what needs to be done. |
orignally this was motaivate by the orginal request for DT which was also communicated as applying to the component piplien and github jobs. later that request was removed but the desire to have a minimal configuration for development and ci this stopped being a ga requirement when having dt for all jobs including upstream github and downstream component pipepliens was removed a few months ago which is why i depriotised this. |
This change adds a readme describing the compute starter kit DT and job variants. This DT may be graducated to a VA in the future and will be used as the basis of the compute content promotion jobs prior to integration of promoted content. This initial patch also include a defintion of the compute-kit controlplane containing only keystone, placement, glance, neutron and nova. it does not contain a dataplane definition. that will be added in later patches. this dt currently deploy nova with only cell 0 cell 1 will be added when adding the dataplane
769000d
to
c960e66
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SeanMooney The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
@SeanMooney: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change adds a redme describign the comptue starter kit
DT and job variants. This DT may be graducated to a VA in the future
and will be used as the basis of the compute content promotion jobs
prior to integration of promoted content.