Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare crc job for architecture repo #1794

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

cescgina
Copy link
Contributor

@cescgina cescgina commented May 30, 2024

Create a job that can deploy the HCI VA with an extracted crc layout.
This change introduces the jobs definition and playbooks for such a job.
It creates and extracted crc layout using ci-bootstrap role
and then calls networking mapper to get the required networking config to
deploy a VA. It needs to generate an interfaces-info file.

Additionally, it changes the 06-deploy-architecture playbook to allow
ssh access from any network to the compute nodes. It also modifies the
multinode-customizations playbook to work with a 'ctlplane' network in
the crc, instead of a 'default' one.

It makes use of scenario inhertance proposed in [1] to reuse most of the
existing HCI VA scenario.

[1] #1491
As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:

Copy link
Contributor

openshift-ci bot commented May 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a3093d29b9544bef8268e52770a253a2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 32s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 58s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci ERROR Unable to find playbook /var/lib/zuul/builds/37bcb2d4b1aa41f998352e7d9d8e514e/untrusted/project_0/github.com/openstack-k8s-operators/ci-framework/ci/playbooks/run-architecture-crc.yml in 7s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 35s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 59s
cifmw-pod-zuul-files FAILURE in 5m 39s
✔️ cifmw-architecture-validate-hci SUCCESS in 6m 04s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch from edb4cd5 to 75508b0 Compare May 30, 2024 18:16
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a26a3535f4bc4ebba975cb082c04a9f8

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 38s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci FAILURE in 4m 28s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 54s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 00s
cifmw-pod-zuul-files FAILURE in 5m 47s
✔️ cifmw-architecture-validate-hci SUCCESS in 7m 05s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch from 75508b0 to fd154d9 Compare May 31, 2024 09:02
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/29d9fd51e04c4b8ea2ab5d8f81553935

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 16s
podified-multinode-edpm-deployment-crc FAILURE in 1h 07m 45s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 54s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci FAILURE in 4m 34s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 29s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 40s
cifmw-pod-zuul-files FAILURE in 5m 21s
✔️ cifmw-architecture-validate-hci SUCCESS in 6m 09s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch from fd154d9 to 02e9210 Compare June 3, 2024 08:19
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 1491,6c98991aa8e37cc125ee81b5dc8a6ab1057c28a2

@cescgina
Copy link
Contributor Author

cescgina commented Jun 3, 2024

recheck

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 1491,6c98991aa8e37cc125ee81b5dc8a6ab1057c28a2

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch from 02e9210 to caea06f Compare June 3, 2024 08:25
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 1491,6c98991aa8e37cc125ee81b5dc8a6ab1057c28a2

@cescgina
Copy link
Contributor Author

cescgina commented Jun 3, 2024

recheck

Copy link

Unable to freeze job graph: Job cifmw-architecture-crc-hci does not specify a run playbook

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch 2 times, most recently from 928c776 to fc84295 Compare June 3, 2024 11:57
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/eee7775f3fe34cad9cfe1d0ef549d4f9

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 43m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 27m 04s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 28s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci FAILURE in 20m 24s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 04s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 16s
cifmw-pod-zuul-files FAILURE in 4m 58s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 43s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch 2 times, most recently from 7b8587d to 0a35ad7 Compare June 3, 2024 15:50
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/299c68c8dba14ee7af3438d2f1042835

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 19s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 20s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci FAILURE in 20m 56s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 27s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 31s
cifmw-pod-zuul-files FAILURE in 4m 55s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 42s

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 1794,fe58ada529250d163eadc2b1b940943eea8efeaa

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0106a912a837473197809cc66c91db62

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 15s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 49s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci FAILURE in 19m 32s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 32s
cifmw-pod-zuul-files FAILURE in 4m 57s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 47s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch from 7317c3f to 603a461 Compare June 4, 2024 16:57
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2b910b2eb8b3403c873ccf071d67f22a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 22s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 28s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci FAILURE in 19m 47s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 38s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 08s
cifmw-pod-zuul-files FAILURE in 4m 53s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 39s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch from 603a461 to f0f85b9 Compare June 5, 2024 09:22
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/73a0aa3cc03a4ddeaf50afcbcb02e1ae

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 49s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci FAILURE in 39m 57s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 24s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 14s
cifmw-pod-zuul-files FAILURE in 4m 47s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 07s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch 2 times, most recently from 699cf8f to a74e33c Compare August 16, 2024 11:31
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e6be06e33da74045accd5d30023ae2c0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 23m 30s
✔️ noop SUCCESS in 0s
cifmw-architecture-crc-hci RETRY_LIMIT Host unreachable in 1h 23m 02s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 04s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 57s
cifmw-pod-zuul-files FAILURE in 4m 28s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 02s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch from a74e33c to fa973da Compare August 16, 2024 13:14
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/efcb418b1bc247d5a6b8fc57a672a7b6

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 23s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 07s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 34s
✔️ noop SUCCESS in 0s
✔️ cifmw-architecture-crc-hci SUCCESS in 1h 27m 53s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 49s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 21s
cifmw-pod-zuul-files FAILURE in 4m 29s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 01s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch 3 times, most recently from 92e0f72 to 04bad98 Compare August 16, 2024 15:41
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/824c21bcf3d947669c59afccdf443dfd

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 02s
✔️ noop SUCCESS in 0s
✔️ cifmw-architecture-crc-hci SUCCESS in 1h 23m 59s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 06s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 11s
cifmw-pod-zuul-files FAILURE in 4m 32s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 07s

@cescgina cescgina force-pushed the prepare_crc_architecture_jobs branch from 04bad98 to c71ca13 Compare August 19, 2024 06:38
@cescgina cescgina marked this pull request as ready for review August 19, 2024 06:38
}}
ci_framework_src_dir: "{{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/ci-framework"
pre_tasks:
- name: Create needed directories
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be done via the ci_setup/directories tasks file (you have to provide directory_state: directory )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good idea, but I'd still need an extra task to create parameters dir, since it's not created by the ci_setup

- "{{ cifmw_manifests | default(cifmw_ci_setup_basedir ~ '/artifacts/manifests') }}/\
and it's needed to store the interfaces-info.yml file

@cjeanner
Copy link
Collaborator

/approve

Won't block on the directory creation comment, might be a follow-up. Seeing this coming is pretty cool!

Create a job that can deploy the HCI VA with an extracted crc layout.
This change introduces the jobs definition and playbooks for such a job.
It creates and extracted crc layout using ci-bootstrap role
and then calls networking mapper to get the required networking config to
deploy a VA. It needs to generate an interfaces-info file.

Additionally, it changes the 06-deploy-architecture playbook to allow
ssh access from any network to the compute nodes. It also modifies the
multinode-customizations playbook to work with a 'ctlplane' network in
the crc, instead of a 'default' one.

It makes use of scenario inhertance proposed in [1] to reuse most of the
existing HCI VA scenario.

[1] #1491

Depends-On: #1491
@son-vyas
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner, son-vyas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rlandy
Copy link
Collaborator

rlandy commented Aug 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 58d1275 into main Aug 22, 2024
5 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the prepare_crc_architecture_jobs branch August 22, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants